Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Oleksandr Mazur <oleksandr.mazur@plvision.eu>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "jiri@nvidia.com" <jiri@nvidia.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC v3 net-next] net: core: devlink: add 'dropped' stats field
 for DROP trap action
Thread-Topic: [RFC v3 net-next] net: core: devlink: add 'dropped' stats field
 for DROP trap action
Thread-Index: AQHW8xcXY5euT+iepUq2JFXYOtkL6Ko42mmAgADVue0=
Date:   Tue, 26 Jan 2021 10:10:06 +0000
Message-ID: <AM0P190MB07380476D3B89CDB50BA4151E4BC0@AM0P190MB0738.EURP190.PROD.OUTLOOK.COM>
References: <20210125123856.1746-1-oleksandr.mazur@plvision.eu>,<20210125132317.418a4e35@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20210125132317.418a4e35@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 06941239-417a-49fb-d9ff-08d8c1e28e0a
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2021 10:10:06.2252
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fCdWyXVkuXnBANVpm4nHIrceNK0ROaCAhvdOsbXM8iO23q+6dJjhMWB9G+ecQQ2btEPUWO4Pd0KglSJgE+UbW7DOVa8nyKpjtccWsTTBH/0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P190MB0947
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 25 Jan 2021 14:38:56 +0200 Oleksandr Mazur wrote:=0A=
> +=A0=A0=A0=A0 if (trap_item->action =3D=3D DEVLINK_TRAP_ACTION_DROP &&=0A=
> +=A0=A0=A0=A0=A0=A0=A0=A0 devlink->ops->trap_drop_counter_get) {=0A=
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 err =3D devlink->ops->trap_drop_cou=
nter_get(devlink,=0A=
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0 trap_item->trap,=0A=
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0 &drops);=0A=
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 if (err)=0A=
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 return err;=
=0A=
> +=A0=A0=A0=A0 }=0A=
=0A=
> Why only report this counter when action is set to drop?=0A=
=0A=
> Thinking about it again - if the action can be changed wouldn't it =0A=
> be best for the user to actually get a "HW condition hit" counter,=0A=
> which would increment regardless of SW config (incl. policers)?=0A=
=0A=
> Otherwise if admin logs onto the box and temporarily enables a trap =0A=
> for debug this count would disappear.=0A=
=0A=
Okay, so should it become like generic HW counter - trap_hw_counter_get?=