Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4109187pxb; Tue, 26 Jan 2021 12:38:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJzfnuFgpOh8wdFiA69EmZuxQCVzYwuVKqZnM/2Ps71g5sIbnm25PEgUV3djqQaIZdTz1LSu X-Received: by 2002:a17:906:174f:: with SMTP id d15mr4603870eje.52.1611693526104; Tue, 26 Jan 2021 12:38:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611693526; cv=none; d=google.com; s=arc-20160816; b=k4TD89VCpsLHvVOAYAxP96sXh6Cv+qBE+FVlVVHdknHZv9sY2BcfM4ERLiEAics9oB GPNLho5S3yVEVYgB6SEdaE2yl7e45/FboljnsoW/jAMyxmY6SbWb4aiFn3nGSCCZPT7E ZHQN4Ik3qRtG5OJGecWj1Dj+QlQstKBF8IqXb6C42F2zwRANi8/a5eHmpRFwSitNZiSu 6B3n7/OMxNYHaPgXOQm+ZdB+CYr9HtWkDlpkUZCrPe/8yhBimpkLvVwOxvNUhR/Foslh VEAmXpY8R6kbND6LfK2KATMUYnpGQsevfcUoz5n3krBkZnhsgkigSxUzeIsjefqqjs7p mffQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=0pOWB42lpMJxuPiZKyXY7i7K3d3bg8hD4DNUs7LKz6I=; b=otbGR+8lG4jaMkvQNIusD+RiAzsZ43JBpxg3Me6+PCeCVvazELZksRNSe1YgdpnjkP NZQ0YQzphlhMRAdZBv4/nKTv44R3OBSQxbTWN2cRI1E5Yr4U2UKm1MAJabIQuFkbGSfo xWVmqhrw4YpLk13aCA3+/anZu244NTPZLvI2PlgUcc63QRdC24dKvJDaZaCDQvNYdOY7 KzdJHoFq81N5q45PV7cDcF+UPS3b9FnRsXbUEfBDg1+gwHYHBSFYQfRK9xzgUNKsE93J QQ2VbrEAzvTUNo0CxhWPuBWYDdrt1f3lfEytc4WijoTz2KVVQ+cPBQC1y1CcJ8O3Petj xY/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jz8si7460767ejb.237.2021.01.26.12.38.20; Tue, 26 Jan 2021 12:38:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391651AbhAZSHq (ORCPT + 99 others); Tue, 26 Jan 2021 13:07:46 -0500 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:43126 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389961AbhAZJ1L (ORCPT ); Tue, 26 Jan 2021 04:27:11 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0UMxxyMj_1611653142; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UMxxyMj_1611653142) by smtp.aliyun-inc.com(127.0.0.1); Tue, 26 Jan 2021 17:25:49 +0800 From: Jiapeng Zhong To: mchehab@kernel.org Cc: sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Jiapeng Zhong Subject: [PATCH] media: atomisp: Simplify the calculation of variables Date: Tue, 26 Jan 2021 17:25:40 +0800 Message-Id: <1611653140-76630-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warnings: ./drivers/staging/media/atomisp/pci/sh_css_params.c:4652:24-26: WARNING !A || A && B is equivalent to !A || B. Reported-by: Abaci Robot Signed-off-by: Jiapeng Zhong --- drivers/staging/media/atomisp/pci/sh_css_params.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/sh_css_params.c b/drivers/staging/media/atomisp/pci/sh_css_params.c index 24fc497..9eb02f4 100644 --- a/drivers/staging/media/atomisp/pci/sh_css_params.c +++ b/drivers/staging/media/atomisp/pci/sh_css_params.c @@ -4649,10 +4649,8 @@ struct ia_css_dvs_6axis_config * params = stream->isp_params_configs; /* Backward compatibility by default consider pipe as Video*/ - if (!params || (params && - !params->pipe_dvs_6axis_config[IA_CSS_PIPE_ID_VIDEO])) { + if (!params || !params->pipe_dvs_6axis_config[IA_CSS_PIPE_ID_VIDEO]) goto err; - } dvs_config = kvcalloc(1, sizeof(struct ia_css_dvs_6axis_config), GFP_KERNEL); -- 1.8.3.1