Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 26 Jan 2021 12:40:32 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Timur Tabi <timur@kernel.org>
Cc:     Vlastimil Babka <vbabka@suse.cz>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Matthew Wilcox <willy@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
        Petr Mladek <pmladek@suse.com>, roman.fietze@magna.com,
        keescook@chromium.org, John Ogness <john.ogness@linutronix.de>,
        linux-mm@kvack.org, Akinobu Mita <akinobu.mita@gmail.com>
Subject: Re: [PATCH 0/2] introduce DUMP_PREFIX_UNHASHED for hex dumps
Message-ID: <20210126124032.0915f408@gandalf.local.home>
In-Reply-To: <20210126123912.23a5c3a1@gandalf.local.home>
References: <20210116220950.47078-1-timur@kernel.org>
        <20210118182635.GD2260413@casper.infradead.org>
        <ed7e0656-9271-3ccf-ef88-153da1ee31c9@kernel.org>
        <YAYtbbHAHeEwunkW@jagdpanzerIV.localdomain>
        <20210119014725.GH2260413@casper.infradead.org>
        <YAa2oCNWjExWlQTu@jagdpanzerIV.localdomain>
        <09c70d6b-c989-ca23-7ee8-b404bb0490f0@suse.cz>
        <cd9e7a31-e4f6-69d3-0648-c6228108b592@kernel.org>
        <083dd940-60c1-4cc8-fc89-8815b253d5c5@suse.cz>
        <a9b38fe7-8a22-71b7-1e84-0ebf1e864306@kernel.org>
        <20210126123912.23a5c3a1@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 26 Jan 2021 12:39:12 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 26 Jan 2021 11:30:02 -0600
> Timur Tabi <timur@kernel.org> wrote:
> 
> > On 1/26/21 11:14 AM, Vlastimil Babka wrote:  
> > > If it was a boot option, I would personally be for leaving hashing enabled by
> > > default, with opt-in boot option to disable it.    
> > 
> > A boot option would solve all my problems.  I wouldn't need to recompile 
> > the kernel, and it would apply to all variations of printk.  
> 
> Should it be called "make-printk-insecure"
> 
> ?

And even if we make this a boot time option, perhaps we should still
include that nasty dmesg notice, which will let people know that the kernel
has unhashed values.

-- Steve