Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 25 Jan 2021 11:55:51 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Like Xu <like.xu@linux.intel.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Borislav Petkov <bp@alien8.de>, x86@kernel.org,
        "H . Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86/perf: Use static_call for x86_pmu.guest_get_msrs
Message-ID: <YA6jtyrbxCSRk/zD@hirez.programming.kicks-ass.net>
References: <20210122030324.2754492-1-like.xu@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210122030324.2754492-1-like.xu@linux.intel.com>
Precedence: bulk

On Fri, Jan 22, 2021 at 11:03:24AM +0800, Like Xu wrote:
> Clean up that CONFIG_RETPOLINE crud and replace the
> indirect call x86_pmu.guest_get_msrs with static_call().
> 

Looks good in principle, but the robot complains about a missing func
decl. I think you removed a little too much when you killed the inline
thing.