Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4386824pxb; Tue, 26 Jan 2021 21:54:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJxvw2L/PeFAmX6TVafKorJFWJkbuZSAbAP9scA/+UrTBnA4nEM1TtqpuvZsglLUWpVEONxK X-Received: by 2002:a50:fd84:: with SMTP id o4mr7476820edt.340.1611726894565; Tue, 26 Jan 2021 21:54:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611726894; cv=none; d=google.com; s=arc-20160816; b=DO5NrWlKk8s0LX757uA9AZ4NwWeSMqjmr7irbt5UE852f6glRntrOMvaE8dVmTDmRf e/119tRKO39bvVlM8thQunJvBC1tVFv09yb6LzrkT9WxQxDY0Mok1HHIlbMlLRxriZ2Y wXsLuneNlSYamRirjArtgs2LmoRSSgytFExwiYXh6CCd30I1wMhExLjSKYfa1l1BMePR 3S0PlN1IZspGOlGvd+q2BvsPZLmGEouOeNGCxMmkhM1HtzYELIdC4UFNAClqp26A81l3 uxXHro3d4n5qNJzhGQBdPm9VltP928wde+5+oLbKKsWCvUVHR135uX1BStoepWIgyV7O kefA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=EIIJnlM3V2I1LE8nxiZcRHnf3owmBupe6IN0h/Lvces=; b=zqEh/gYuGw9k1BDhZWlAC3gqoq2AM3M36bqstH3p2WNgU1N6m60ETquCwglRp9vGkD Bgw+YBTXqOh46dm4/r62ua3OCzRiHo30nefJGtSQ15Oz/eIBpm3YmMClv4qX+qkZnZIB rkrcqvVoAHDn3MQ/fyXE/lvpo4iSVX5mT0ATJqva5/TQdNYCBy/LuP5pWdC+ddqXQ3fe 1BzwbIWYz74nJqpDZo5AIgFUJWkMPoljmVYE2j5v/hizMPg7anEHlhWttIXlD8D3Xlop 0q3RSc4c6BgRAUGDrH6xKKWdm/lkxrVJEpmpo201ySUq6SU1qeBXwBeAiDeOobKm0NzM syEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t24si398146ejr.255.2021.01.26.21.54.30; Tue, 26 Jan 2021 21:54:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390743AbhAZRUM (ORCPT + 99 others); Tue, 26 Jan 2021 12:20:12 -0500 Received: from out30-132.freemail.mail.aliyun.com ([115.124.30.132]:37649 "EHLO out30-132.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388545AbhAZGgm (ORCPT ); Tue, 26 Jan 2021 01:36:42 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0UMxNWQf_1611642950; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UMxNWQf_1611642950) by smtp.aliyun-inc.com(127.0.0.1); Tue, 26 Jan 2021 14:35:54 +0800 From: Jiapeng Zhong To: njavali@marvell.com Cc: mrangankar@marvell.com, GR-QLogic-Storage-Upstream@marvell.com, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Zhong Subject: [PATCH] scsi/qla4xxx: Simplify the calculation of variables Date: Tue, 26 Jan 2021 14:35:48 +0800 Message-Id: <1611642948-43192-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warnings: ./drivers/scsi/qla4xxx/ql4_83xx.c:475:23-25: WARNING !A || A && B is equivalent to !A || B. Reported-by: Abaci Robot Signed-off-by: Jiapeng Zhong --- drivers/scsi/qla4xxx/ql4_83xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_83xx.c b/drivers/scsi/qla4xxx/ql4_83xx.c index 5f56122..64244a6 100644 --- a/drivers/scsi/qla4xxx/ql4_83xx.c +++ b/drivers/scsi/qla4xxx/ql4_83xx.c @@ -471,9 +471,7 @@ int qla4_83xx_can_perform_reset(struct scsi_qla_host *ha) } } else if (device_map[i].device_type == ISCSI_CLASS) { if (drv_active & (1 << device_map[i].func_num)) { - if (!iscsi_present || - (iscsi_present && - (iscsi_func_low > device_map[i].func_num))) + if (!iscsi_present || (iscsi_func_low > device_map[i].func_num)) iscsi_func_low = device_map[i].func_num; iscsi_present++; -- 1.8.3.1