Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4386888pxb; Tue, 26 Jan 2021 21:55:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJxZMIZiOhSYd443Z590yoBqmMOSqEJcfyje0Jh0KfO8YBSBcCjNyyaNHNNGfubEFwVz/Dch X-Received: by 2002:a17:906:934c:: with SMTP id p12mr5495648ejw.269.1611726902383; Tue, 26 Jan 2021 21:55:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611726902; cv=none; d=google.com; s=arc-20160816; b=kqrBnE5RpWYe3wcjsz7eW/RXA3mG8fyyXFc0HUs2es5B1G+CSmVWo5i0EIAjWtfeP+ PT1YaEhAFMxBjM17tAQBBYs7YjrS9ZAt54QyZTC2AqUf+f8G0T9U6nDCoOGPeN1a1F5I CxAXAuXJIYh1mG/xGHFAnWvPrZKQS8mYXDgbelZj0dSr8icqMvVdNjMkfUSxAIpQjoPu ZW2BeaGS5JF3PEBTeonPmlMqJlsv8HoVY9aDh8tj2IhNjmUVbfukiZMC4VK485qINd7u xiWa5iXkKkWzAFS8o4cU92WolBTpi0KX5U7BVTJa0H1VC43vvKLXGmN0S7ADliSBJIQc GpAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=c4c2KO5HxUbKgdlHKlBJ7kXGc1TGsPSgpYK6riDG7Ac=; b=Affax6eOyaOy3NmJWDHo2Q/R6ASiCNjCirjButfXyOs3GAKYqiKcY57Ob1EPbRmZ0u SLMF27WcPeDa+oxud+0k3OhOF21EDRNmRnLtuGxxMcP14tn97k+7aI6IcIYKzFnAruOl 2s4LovC2ne2zFQxCO+BbYIQNeij7m6JL5KQ3pyEpEgtHfz3AH+pbEgLAJ418r56lj6Ru F14XisxqIw2RfcPpwgBVS71xj6XrtM5a2hBY4qVaR5mqAaoIF50FNvi4BMMAobHVKoEO B+kYVW/pmWvT9WbZpYR/lRKQ5R5h8RuxyrxXzhsjMNelQGcLFrWt7+x8jZ96bqcFlBmp OJYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b7si457465edq.542.2021.01.26.21.54.39; Tue, 26 Jan 2021 21:55:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389986AbhAZRQL (ORCPT + 99 others); Tue, 26 Jan 2021 12:16:11 -0500 Received: from out4436.biz.mail.alibaba.com ([47.88.44.36]:28067 "EHLO out4436.biz.mail.alibaba.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387444AbhAZGWi (ORCPT ); Tue, 26 Jan 2021 01:22:38 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0UMxNTrM_1611642101; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UMxNTrM_1611642101) by smtp.aliyun-inc.com(127.0.0.1); Tue, 26 Jan 2021 14:21:46 +0800 From: Jiapeng Zhong To: linux@roeck-us.net Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Zhong Subject: [PATCH] hwmon: (pmbus) Simplify the calculation of variables Date: Tue, 26 Jan 2021 14:21:40 +0800 Message-Id: <1611642100-29937-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warnings: ./drivers/hwmon/pmbus/pmbus_core.c:1265:24-26: WARNING !A || A && B is equivalent to !A || B. Reported-by: Abaci Robot Signed-off-by: Jiapeng Zhong --- drivers/hwmon/pmbus/pmbus_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c index 192442b..a78ae70 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -1262,7 +1262,7 @@ static int pmbus_add_sensor_attrs_one(struct i2c_client *client, * which global bit is set) for this page is accessible. */ if (!ret && attr->gbit && - (!upper || (upper && data->has_status_word)) && + (!upper || data->has_status_word) && pmbus_check_status_register(client, page)) { ret = pmbus_add_boolean(data, name, "alarm", index, NULL, NULL, -- 1.8.3.1