Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 26 Jan 2021 09:05:25 +0100
From:   Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To:     Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Cc:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "rppt@kernel.org" <rppt@kernel.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "jason@lakedaemon.net" <jason@lakedaemon.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        =?UTF-8?B?R3LDqWdvcnk=?= Clement <gregory.clement@bootlin.com>
Subject: Re: [PATCH] bus: mvebu-mbus: make iounmap() symmetric with
 ioremap()
Message-ID: <20210126090525.4d085080@windsurf.home>
In-Reply-To: <7c0fd747-3ea1-2aa1-0c05-12ae4477a860@alliedtelesis.co.nz>
References: <20201112032149.21906-1-chris.packham@alliedtelesis.co.nz>
        <20201112090202.638c0c13@windsurf>
        <7c0fd747-3ea1-2aa1-0c05-12ae4477a860@alliedtelesis.co.nz>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 26 Jan 2021 01:48:23 +0000
Chris Packham <Chris.Packham@alliedtelesis.co.nz> wrote:

> Hi All,
> 
> On 12/11/20 9:02 pm, Thomas Petazzoni wrote:
> > On Thu, 12 Nov 2020 16:21:49 +1300
> > Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
> >  
> >> make coccicheck complains:
> >>
> >>    ./drivers/bus/mvebu-mbus.c:1113:2-8: ERROR: missing iounmap; ioremap on line 1106 and execution via conditional on line 1111
> >>
> >> It took some staring but I don't think there is a problem because the
> >> file global `mbus_state` is passed mvebu_mbus_common_init() as the
> >> `mbus` parameter so `mbus_state.mbuswins_base` and `mbus->mbuswins_base`
> >> are the same thing. But this is confusing for anyone reading the code
> >> and one less complaint from coccicheck would be nice so lets fix it.
> >>
> >> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>  
> > Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>  
> 
> Just going through some old branches. This doesn't seem to have been 
> picked up. Have I missed a maintainer?

+Gregory Clement in Cc. Greg, the original patch from Chris is touching
drivers/bus/mvebu-mbus.c, so I think you should be taking that patch.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com