Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4389422pxb; Tue, 26 Jan 2021 22:00:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJw3E8WJd29ryECTFz5oZcjCJTI9C27bHnMlk+FICg5WFMDN26YJL776EnWHWEHq36RCX55Y X-Received: by 2002:aa7:c784:: with SMTP id n4mr7195514eds.332.1611727245187; Tue, 26 Jan 2021 22:00:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611727245; cv=none; d=google.com; s=arc-20160816; b=hxruk1GQd9Wun8v8Q6Xb5QKqIWKzmD7bvuXSKvXiuWCam9AtNKCVH/yyCeWT4iVKOe puO3LWV5DVXOrr5dhD3BDv60gBnfkNOqaqnk8HV7gadrX5BU6DuBBkdYJIfV8ZbFl324 AoxApG1UtpoD9PhJ1dwoLNn81AoDdiExshhcjv118NJtC8Jm1FIIjvgztfYFmZkc9HoY GHhaB+fmVKCvP4F9shm3eu4JQbNjomPugsHTTXT+omKmuPVqlUBVTY0Vb9Svgz3kQsq9 /1ydog+aZKF1JhlZ/QlpJknWDQo2SnmEH0uXQze4zPKMzvMKhhxDFFv9DDduEY55pnof 8SpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=cdPnxzbMQJ6jI5dWeUlt3YT7GdQkWdgogy5U5P/fy0Q=; b=JeInUIbuljjA3NovgYNneLpQc7s+Eg0i2YCSW7wUIvLFVQ1PBkRNwvrpm1JfOEkcsf CkYDcQdBlvjiBUfQy68aTakV/bRNGkLf7tw1+5vW5bkGzC37rED0YiomxIobhIvck330 bojNxAYEYaJNMuqJwULn0+vZmyq7efb5c/qPLBMMmiY290CZNpcQ0N9DDhnKvuHBw69F vP++VlYNv5haPXHts1mSKis44yT5/kjSzsWWVbNClhwuhpMjss0z2NQ3fd+QUYBPjqk+ +oHd3xrVWIQ/oV+oDI8MCrmr6MS60e9Sf/uqgl0u/DhjJrTxBcKU68w1GbhkJevS5r5n KkVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z5si511410edp.368.2021.01.26.22.00.21; Tue, 26 Jan 2021 22:00:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393227AbhAZRqF (ORCPT + 99 others); Tue, 26 Jan 2021 12:46:05 -0500 Received: from out30-131.freemail.mail.aliyun.com ([115.124.30.131]:41394 "EHLO out30-131.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389726AbhAZIOB (ORCPT ); Tue, 26 Jan 2021 03:14:01 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04357;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UMxk8Ir_1611648784; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UMxk8Ir_1611648784) by smtp.aliyun-inc.com(127.0.0.1); Tue, 26 Jan 2021 16:13:08 +0800 From: Jiapeng Zhong To: jiri@resnulli.us Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Zhong Subject: [PATCH] rocker: Simplify the calculation of variables Date: Tue, 26 Jan 2021 16:13:03 +0800 Message-Id: <1611648783-3916-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warnings: ./drivers/net/ethernet/rocker/rocker_ofdpa.c:926:34-36: WARNING !A || A && B is equivalent to !A || B. Reported-by: Abaci Robot Signed-off-by: Jiapeng Zhong --- drivers/net/ethernet/rocker/rocker_ofdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/rocker/rocker_ofdpa.c b/drivers/net/ethernet/rocker/rocker_ofdpa.c index 7072b24..e2d5962 100644 --- a/drivers/net/ethernet/rocker/rocker_ofdpa.c +++ b/drivers/net/ethernet/rocker/rocker_ofdpa.c @@ -923,7 +923,7 @@ static int ofdpa_flow_tbl_bridge(struct ofdpa_port *ofdpa_port, struct ofdpa_flow_tbl_entry *entry; u32 priority; bool vlan_bridging = !!vlan_id; - bool dflt = !eth_dst || (eth_dst && eth_dst_mask); + bool dflt = !eth_dst || eth_dst_mask; bool wild = false; entry = kzalloc(sizeof(*entry), GFP_ATOMIC); -- 1.8.3.1