Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4397264pxb; Tue, 26 Jan 2021 22:15:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJzSnhbJgKbs8az/KBLHFxh0nQjjA67iJPhnlz/eDVEZkZ723pwnL0Z3KisZsBk8lAyNzTCp X-Received: by 2002:a05:6402:ce:: with SMTP id i14mr7464125edu.42.1611728144650; Tue, 26 Jan 2021 22:15:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611728144; cv=none; d=google.com; s=arc-20160816; b=QMcJZMzNghoGK6QvR0t3I2lp+yxu26jDP0d/FPLccvRjN4WuqvnUq8Y9Ih+7lkAZq+ pAds8tPvqPRAT8QpjL0KiOQtIjAHx00Cu3i2UrTNeKb7aVJ3Ot9P8zYhRn94vxDodTx8 BgEZ0wNLtX/340VUIvs5xVCaEPpmqsNLk9KFTVokcTdv5KXUkINXt+1nZzvLRfkLm2cn 7uZWeuqpKf50MtV9gMv4QP+4/ESG5QiGKTDVmXw5pdIN8ZG4X8x/oSLTMa2hG+xSzdry 0oxu+RGZqt7nuUTZCekiMBAE/6WEv39V3R/n/1/0kORDuI88u8hx23s4sUhmNYqTL4zu hSIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=X5PkMPzJ7iqYXA0xkIfBGT1YalMSvtLoNWJvwSFMXeQ=; b=kXvAC/QO3/ijT2saLf+U7D52qBgvDXqczxtJSeU1ECarWv8faSlJTmAZNn68lAZ0BH JXL0cKaiD9C8QDSyCuIjp3kvtVrFFoLoe+z2tc98IxvjNCChw+m7YyWUb/Qh7+Al0Aoe a5P+BnusnjgXce6brJkGxM7PSvKkxZIavzYDXekmFsGG0MLSxareXyRXvE/8ybehOtAG 3gTYM2SKhuZsfuGIezKz4u5GePYfIaAu+ENX5vvZSN3pcbH7DgVmbnOqervLWaIIG/O+ eMurJYu5Bh1mOz9chrWyDMg5qK1RoQ4c4ifoCcmSSs9fh/qHKECVDopSEdn6p9lpu0fs yCag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JqsBZ2WC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e8si483025edn.494.2021.01.26.22.15.18; Tue, 26 Jan 2021 22:15:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JqsBZ2WC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394253AbhAZSN1 (ORCPT + 99 others); Tue, 26 Jan 2021 13:13:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:37440 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391784AbhAZRcu (ORCPT ); Tue, 26 Jan 2021 12:32:50 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id A9FD420449; Tue, 26 Jan 2021 17:32:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611682329; bh=aevOU/oAUIC45KM/PiKluJZqSZNzHEmWriiswuFkqh8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JqsBZ2WCzFqanJpjrpk5S3Hyq0sQRKB5+GVebNWa4w2G5eGpfYu6ICpYht+WZEDxC k4pBRKie0uopmyYHEyhLXuksXxvF09sy8/T0x4mhUdhfJ/sn4qO76QwJYJZHikWUfY I8WQ9EQN04UuYrQb4zYeuxT5Qu9SdicKD4zVtlJE3RkHwSgDFdLV9FVqd+T0mmfX0D AcrmY0R3+k5e0RwfjDCtG7+ODYIHjPcM0FEFnbmVNgJIn+NioYO5EwXR08sBYy9jqt NtQ2SL5LSiWJjVZTVkVqUbWjRFp4wsLtB36AUk17lpd49yNHepMDRTWIOKj4Xj1xTw ihrCh27jT1NRQ== Date: Tue, 26 Jan 2021 23:02:05 +0530 From: Vinod Koul To: Christophe JAILLET Cc: peter.ujfalusi@gmail.com, dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] dmaengine: ti: k3-udma: Fix a resource leak in an error handling path Message-ID: <20210126173205.GZ2771@vkoul-mobl> References: <20210124070923.724479-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210124070923.724479-1-christophe.jaillet@wanadoo.fr> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24-01-21, 08:09, Christophe JAILLET wrote: > In 'dma_pool_create()', we return -ENOMEM, but don't release the resources > already allocated, as in all the other error handling paths. > > Go to 'err_res_free' instead of returning directly. Applied, thanks -- ~Vinod