Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] cmd_dtc: Enable generation of device tree symbols
To:     Geert Uytterhoeven <geert@linux-m68k.org>,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <uwe@kleine-koenig.org>,
        Frank Rowand <frowand.list@gmail.com>
Cc:     DTML <devicetree@vger.kernel.org>,
        Michal Marek <michal.lkml@markovi.net>,
        Arnd Bergmann <arnd@arndb.de>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Maxime Ripard <mripard@kernel.org>, cyril@debamax.com,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
References: <20210125105757.661240-1-uwe@kleine-koenig.org>
 <CAK7LNAS5t1wew0MMFjdB5HGCAMerhU7pAGiFhcTtCRUAAjGLpw@mail.gmail.com>
 <9d9bb0f6-d4f4-b1b9-a4c4-786987578085@kleine-koenig.org>
 <CAMuHMdUmtMxucQ9DWvROVPVv2uGEzpRmtv1=jrjm09xU=gHHyw@mail.gmail.com>
From:   Frank Rowand <frowand.list@gmail.com>
Message-ID: <1e713129-db54-64c3-59e3-fc0dba0e0f19@gmail.com>
Date:   Tue, 26 Jan 2021 12:03:56 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CAMuHMdUmtMxucQ9DWvROVPVv2uGEzpRmtv1=jrjm09xU=gHHyw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

+frank

On 1/26/21 2:43 AM, Geert Uytterhoeven wrote:
> Hi Uwe,
> 
> On Tue, Jan 26, 2021 at 8:21 AM Uwe Kleine-König <uwe@kleine-koenig.org> wrote:
>> And then I learned with hints from Rob and Geert that symbols are not
>> really necessary for overlays, you just cannot use named labels. But
>> using
>>
>>         target-path = "/soc/i2c@23473245";
>>
>> or
>>
>>         target = <&{/soc/i2c@23473245}>;
>>
>> instead of
>>
>>         target = <&i2c1>;
>>
>> works fine. (And if you need to add a phandle the &{/path/to/node}
>> construct should work, too (but I didn't test).) Using labels is a tad
>> nicer, but the problem I wanted to address with my patch now has a known
>> different solution.
> 
> Please don't use "target" and "target-path".  Since the introduction of
> sugar syntax support in v4.15[1], you can just use "&label", like in a normal
> DTS file.  Paths do need the special "&{/path/to/node}" syntax instead
> of "/path/to/node", though.
> 
> As usual, you can find lots of examples of DT overlays in my repo[2].
> 
> [1] commit 4201d057ea91c3d6 ("scripts/dtc: Update to upstream version
> v1.4.5-3-gb1a60033c110")
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/log/?h=topic/renesas-overlays
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
>