From: Dmitry Torokhov <dtor@insightbb.com>
To: Om Narasimhan <om.turyx@gmail.com>
Subject: Re: kmalloc to kzalloc patches for drivers/base
Date: Sun, 17 Sep 2006 21:08:36 -0400
User-Agent: KMail/1.9.3
Cc: linux-kernel@vger.kernel.org, kernel-janitors@lists.osdl.org
References: <6b4e42d10609171753m2a047081qc2982bf4a693a044@mail.gmail.com>
In-Reply-To: <6b4e42d10609171753m2a047081qc2982bf4a693a044@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Message-Id: <200609172108.37707.dtor@insightbb.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1217
Lines: 38

On Sunday 17 September 2006 20:53, Om Narasimhan wrote:
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index 2b8755d..e08950b 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -192,7 +192,7 @@ int platform_device_add_resources(struct
> ?{
> ????????struct resource *r;
> 
> -???????r = kmalloc(sizeof(struct resource) * num, GFP_KERNEL);
> +???????r = kzalloc(sizeof(struct resource) * num, GFP_KERNEL);
> ????????if (r) {
> ????????????????memcpy(r, res, sizeof(struct resource) * num);
> ????????????????pdev->resource = r;

Just out of curiosity could you tell me what is the benefit of
zeroing allocated memory here?

> @@ -216,7 +216,7 @@ int platform_device_add_data(struct plat
> ?{
> ????????void *d;
> 
> -???????d = kmalloc(size, GFP_KERNEL);
> +???????d = kzalloc(size, GFP_KERNEL);
> ????????if (d) {
> ????????????????memcpy(d, data, size);
> ????????????????pdev->dev.platform_data = d;
> 

And here?

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/