From: Dmitry Torokhov <dtor@insightbb.com>
To: Om Narasimhan <om.turyx@gmail.com>
Subject: Re: kmalloc to kzalloc patches for drivers/atm
Date: Sun, 17 Sep 2006 21:19:19 -0400
User-Agent: KMail/1.9.3
Cc: linux-kernel@vger.kernel.org, kernel-janitors@lists.osdl.org,
       linux-atm-general@lists.sourceforge.net
References: <6b4e42d10609171753i63697c8et3e6e1c5706b60d5f@mail.gmail.com>
In-Reply-To: <6b4e42d10609171753i63697c8et3e6e1c5706b60d5f@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Message-Id: <200609172119.20555.dtor@insightbb.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1038
Lines: 24

On Sunday 17 September 2006 20:53, Om Narasimhan wrote:
> --- a/drivers/atm/firestream.c
> +++ b/drivers/atm/firestream.c
> @@ -1784,7 +1784,7 @@ static int __devinit fs_init (struct fs_
> ????????????????write_fs (dev, RAM, (1 << (28 - FS155_VPI_BITS - FS155_VCI_BITS)) - 1);
> ????????????????dev->nchannels = FS155_NR_CHANNELS;
> ????????}
> -???????dev->atm_vccs = kmalloc (dev->nchannels * sizeof (struct atm_vcc *),
> +???????dev->atm_vccs = kzalloc (dev->nchannels * sizeof (struct atm_vcc *),
> ???????????????????????????????? GFP_KERNEL);
> ????????fs_dprintk (FS_DEBUG_ALLOC, "Alloc atmvccs: %p(%Zd)\n",
> ???????????????? ? ?dev->atm_vccs, dev->nchannels * sizeof (struct atm_vcc *));
> 

kcalloc would be better here because you are allocating several objects
at once.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/