Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp454602pxb; Wed, 27 Jan 2021 11:51:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJy8nFZ6KuhPc4tn5XYgEPDfAV4du92ApceDSjDxisnQUvHQhXEQ4XUlnxDFmAK+pbOXW4AX X-Received: by 2002:a50:a086:: with SMTP id 6mr10426193edo.70.1611777075152; Wed, 27 Jan 2021 11:51:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611777075; cv=none; d=google.com; s=arc-20160816; b=KWPQI7GSnZTjBE7cHzfIeNABBRNpFusCjiCyjVTF+Zs3a7ONBP+4cP2teQJZTjcOQh ScAAVdXGgTHytGZoQ5o2jGv9eaN3GiZZYKnPS69ffj6s7PWaDhSI+DT01nXYQPlQ6Gv2 qSLknRxhxebM6KYJeRRnYvihYHEDRwRsa1Zs/ycHFUMJltnV8WnQaNyM0h8LWbU+oZvP cAkpLf29JOn5LOMHhN2oUXx+SZIylmsV7SGb1Yjhbamlo07/v/IyadXriEesgNSRYoiL uVJQRx0geSpI2T8+QMhyT50r1OaECew/gWn7PHQ2v2F6nt+5tio1aOKyYzmDN1sCO3bm NcnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=ZzjmGy0oL0rvnaJhjHzvUitQdjvDnUa+214czaKdGnA=; b=arAhv9YYZRt4BvLpjDRRB+VVMiKFw5X2dMdHZiIzj6JZrDcG7xLC8wY6Lm3v0OWj6f sasP1JlqfyDq4xPadb33EPwYCc8pKqjr18TgLRcq2sFLftlv9PYUEF9rxjs6NzIvNSJW Kr6Ygtq7H9zrNoVNdtQ+6TrerDqPPc3upAHXDcBeN6bzUxP4WtNkvsDHRRKguq3M3JkO 1nw6iK/MXQYBt3e6LaWpyMEWmgmpAAKF0q7nt32+LFjTi/0EaaZYRNpLw2DdCtVFtHLt BR//YpfFLkgCfbIoqGhYlQN/EhvduVA+DpN2ERA7BTzJMUy0sYU60+Xj9bkfqJBPlV5c ltug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@paul-moore-com.20150623.gappssmtp.com header.s=20150623 header.b=oF2cQsl0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o2si1255621ejn.501.2021.01.27.11.50.50; Wed, 27 Jan 2021 11:51:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@paul-moore-com.20150623.gappssmtp.com header.s=20150623 header.b=oF2cQsl0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235123AbhA0DPn (ORCPT + 99 others); Tue, 26 Jan 2021 22:15:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392321AbhAZUG1 (ORCPT ); Tue, 26 Jan 2021 15:06:27 -0500 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D486C061756 for ; Tue, 26 Jan 2021 12:05:45 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id z22so6576438edb.9 for ; Tue, 26 Jan 2021 12:05:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZzjmGy0oL0rvnaJhjHzvUitQdjvDnUa+214czaKdGnA=; b=oF2cQsl0GAPwXBG2Ww0q9O85pkErIVGR2iQFzCl3fyldSMMolS50vS13rcLJUZGn0q pWPzzZN7kJVj6PNIIDihPQ57NR1AUnLEZ7OFW0/nYImJ4O+ZSVaRAzeXPqr1Ou4HQ7Ib u3Bj3rVKwapzmtfGoc1+yAu86eqwhaKzCU8dozKHNLfKgBn5LPOGm3HhuJnY1wVdxqlJ z2Gf7ICdQXPK2WcXlP+fFEcodWWsIEEXXcZYZe9hz1V2UqLzm6WIVW3Ou4BmNQ3zca0o QbwqAxnBI1Kf397ABOuX+Ob4ps7I34H2A15bCd8uRPvhV1pydBKEhcb8/fTV6Pl/1aFl z82g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZzjmGy0oL0rvnaJhjHzvUitQdjvDnUa+214czaKdGnA=; b=ghNJbardo3R9HivRnKQjlMq6nJbBTQlDzTOQCOaMlHEmM7+2AjAq7ziEYtKYjFfj6Z eTqKzsUDqiQTj3/RyfzUSUOqTEByBDlFU4bzadxG7nO3EZyG/k02nU0pt6I6AUbsfMNf qSwMlTL9wSDJN+8F6rz9SupzDq4ARxl8AuboQrtWKbUKF/5kj+194QMW/2Kbhd1n/gNt pQeDnavCw8NkNZwiXdbkF7osqp3P5p7jEU0P0cY+cJOg8VyGOwqd3dtpHwh5u+vAkViF C4/1RGSA/1YeiTeRiYmmC7svuScp1GeTjpBgX5P8GJNnVYluskNF1049mKPPElpxbVrk DhlQ== X-Gm-Message-State: AOAM530c1C16UWELrEDIEVWxKwPx3zzm0UL3MfhSay1sL72Rf3OINoi+ fpqL3YFn48zy1mfKz8RrCIpWG/pQtrW6Dk4qfuFC X-Received: by 2002:a05:6402:54d:: with SMTP id i13mr5868684edx.12.1611691543921; Tue, 26 Jan 2021 12:05:43 -0800 (PST) MIME-Version: 1.0 References: <20210126164108.1958-1-casey@schaufler-ca.com> <20210126164108.1958-22-casey@schaufler-ca.com> <20210126184246.GM1762914@madcap2.tricolour.ca> In-Reply-To: From: Paul Moore Date: Tue, 26 Jan 2021 15:05:32 -0500 Message-ID: Subject: Re: [PATCH v24 21/25] audit: add support for non-syscall auxiliary records To: Casey Schaufler Cc: Richard Guy Briggs , casey.schaufler@intel.com, James Morris , linux-security-module@vger.kernel.org, selinux@vger.kernel.org, linux-audit@redhat.com, keescook@chromium.org, john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp, Stephen Smalley , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2021 at 1:58 PM Casey Schaufler wrote: > > On 1/26/2021 10:42 AM, Richard Guy Briggs wrote: > > On 2021-01-26 08:41, Casey Schaufler wrote: > >> Standalone audit records have the timestamp and serial number generated > >> on the fly and as such are unique, making them standalone. This new > >> function audit_alloc_local() generates a local audit context that will > >> be used only for a standalone record and its auxiliary record(s). The > >> context is discarded immediately after the local associated records are > >> produced. > >> > >> Signed-off-by: Richard Guy Briggs > >> Signed-off-by: Casey Schaufler > >> Cc: linux-audit@redhat.com > >> To: Richard Guy Briggs > > This has been minorly bothering me for several revisions... Is there a > > way for the development/authorship to be accurately reflected > > if/when this patch is merged before the contid patch set? > > I don't know the right way to do that because I had to pull > some of what was in the original patch out. Any way you would > like it done is fine with me. I'm not sure if there is one perfect way. I typically see either a "From: " line if the author is different from the submitter, or in more complex cases such as this it seems like a simple note giving credit in the description might be the best option. -- paul moore www.paul-moore.com