Date: Mon, 18 Sep 2006 13:34:31 +1000
From: David Chinner <dgc@sgi.com>
To: "Josef 'Jeff' Sipek" <jeffpc@josefsipek.net>
Cc: linux-kernel@vger.kernel.org, xfs-masters@oss.sgi.com, akpm@osdl.org,
       dhowells@redhat.com
Subject: Re: [PATCH 5 of 11] XFS: Use SEEK_{SET, CUR, END} instead of hardcoded values
Message-ID: <20060918033431.GV3034@melbourne.sgi.com>
References: <patchbomb.1158455366@turing.ams.sunysb.edu> <4cdee5980dad9980ec8f.1158455371@turing.ams.sunysb.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4cdee5980dad9980ec8f.1158455371@turing.ams.sunysb.edu>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1237
Lines: 34

On Sat, Sep 16, 2006 at 09:09:31PM -0400, Josef 'Jeff' Sipek wrote:
> XFS: Use SEEK_{SET,CUR,END} instead of hardcoded values

The hard coded values  used in xfs_change_file_space() are documented as part
of the API to the userspace functions that use this interface in xfsctl(3).
That is:

  XFS_IOC_FREESP
  XFS_IOC_FREESP64
  XFS_IOC_ALLOCSP
  XFS_IOC_ALLOCSP64

  Alter storage space associated with a section of the ordinary file specified.
  The section is specified by a variable of type  xfs_flock64_t,  pointed  to  by
  the  final argument.  The data type xfs_flock64_t contains the following
  members: l_whence is 0, 1, or 2 to indicate that the relative offset l_start
  will be measured from the start  of  the  file,  the current  position, or the
  end of the file, respectively.

Hence I think that the hard coded values should not be changed to something
that is defined outside of XFS's API.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/