Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 26 Jan 2021 17:08:46 -0500
From:   Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To:     Nicholas Piggin <npiggin@gmail.com>
Cc:     linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
        Robin Murphy <robin.murphy@arm.com>,
        Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/5] kernel/dma: remove unnecessary unmap_kernel_range
Message-ID: <YBCS7toITTwP04aK@Konrads-MacBook-Pro.local>
References: <20210126045404.2492588-1-npiggin@gmail.com>
 <20210126045404.2492588-3-npiggin@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210126045404.2492588-3-npiggin@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from Konrads-MacBook-Pro.local (138.3.200.9) by CH2PR17CA0021.namprd17.prod.outlook.com (2603:10b6:610:53::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.15 via Frontend Transport; Tue, 26 Jan 2021 22:08:50 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6b955be9-2bd8-4d60-27c0-08d8c246f774
X-MS-TrafficTypeDiagnostic: SJ0PR10MB4559:
X-Microsoft-Antispam-PRVS: <SJ0PR10MB45596DDD28E249A71D3B073F89BC9@SJ0PR10MB4559.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2733;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: sVGmA2HwEi1i5ZZvU4FUaSUTZ+tWHBfbJww3dSpf971aQu3quuEGSBr2M+O4NZXpypugw1kroKzFMjxHPLj4AvIiIsGAvytBPJKx6TGV8MB0z+qv6B25YXfjTDd3Mv+Ro1VgokKjyuPg16xNSlG2nGSPbV600aBRVMbp6PcWoRQnWG7NUp4+QRLSLlplxzpmuWKh38VsK/SfvKNnZn7y4uFAwjU5tVrTm2OeKmosg6hsbpuTvR7WGojL9it6AVl+bJzWsVAC5BMxgDSODpscJ+pBnRdZkIngXX9Bs1CjrerRzQeCKTYlnYoap16JrISDPAKejoWyxj2dFu7kwCKKdS5ifxQdYU8Psu4FMvrXRjPU1MixuU3HySrggCjR8r6yT4DKiLIe8SvgYDM/LdBv4WEF8zylV76RuFe8dIZbrUyBGDAzvK6wcQtdUw0rODgxseimje9Onjhe91VEwe+wUw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2999.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(376002)(396003)(366004)(39860400002)(136003)(478600001)(316002)(86362001)(956004)(4744005)(5660300002)(966005)(7696005)(6666004)(83380400001)(54906003)(2906002)(16526019)(52116002)(66476007)(26005)(6916009)(55016002)(66946007)(186003)(9686003)(66556008)(8936002)(8676002)(6506007)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?FgL5Btt7ay+QCa/R0U3lDslNVRtiHRvudw8xpOFJuiRHDL6FY6LWUBMoBdFn?=
 =?us-ascii?Q?C347AFuCUuIRJAE0mfzxMCYWoudvnw6oX0GcBsAmpmOO/ma9xVLmmnphYurQ?=
 =?us-ascii?Q?7pnZcZq3y0DaNq/+bf/Sp/N+9y0G1EYV0nQHUpLIACOo2vD83DuPPuzVJkuQ?=
 =?us-ascii?Q?ZpxWgFpJN6VYIoG/5GJc3Hi71m8vQ6C+BfqdJH3GsCCZUaAEXTci0IGLPRqt?=
 =?us-ascii?Q?xuzAEoR4Jai7MnqBEIp75aB0xWT/0XmugmUbjPo1sgmK0cvlgf5PnbmPuxeO?=
 =?us-ascii?Q?tO5XiFToHMFR98D4Ov7FdgS9RSnwTKbE2zEweUUzwDrCB0yAjHJYPHNsAKn4?=
 =?us-ascii?Q?U7+PiIHRPkjIYqVgz6S9FLC3s2Je9baguJ7oy9jfGfPaC7cKpBmHVaT3OdZf?=
 =?us-ascii?Q?OrRDpOPkfpFWhXSJVodg2TYDlk0d/8UdkLDKVkS5eEAw57u95zbuf3vny6OM?=
 =?us-ascii?Q?28Kx3KDxgq+IeEDD28ACvSNtusmyor0mkMB2KW4BhP35X436bV8ckftqPgYY?=
 =?us-ascii?Q?FnpENLS1c6NEnklB+4HcZTPJIJPpErHfJGkyCOD/lDzKqiKH9kPWdGWgB90E?=
 =?us-ascii?Q?IuHHjmSTE4HCusyLyIRCis8EeOKC3VlyaucoIwEQcpaSyr5k+Q1CLO6ZmTh1?=
 =?us-ascii?Q?3y9bpTC/Hgg8pKXwaURVeTjWefBbJv2qUfbVEgZRbXTQiseBWnTvr4ixcQYL?=
 =?us-ascii?Q?UtZhQhtRvV8spIavgRqFOSxvL9pIFK+p8bzq3qvvFY0BWQZEiIMrVoH2e4CA?=
 =?us-ascii?Q?UMeKEUHhAWd+C9NxTRQJVPnN+p0uXQUjzent3wufffsWNmzjS5IEObmIzcB2?=
 =?us-ascii?Q?n9ZTQSY7627MxUwIubhTkprz37E91si3Ygn1qTEnDzXV7U0xh7YF3J06sLnE?=
 =?us-ascii?Q?mmshaLPxjDkbSJg/CoxXOu503uHIGENMiHfp8BsHMo2yml2n1bTYBidiVBfK?=
 =?us-ascii?Q?dbFmENWX5wM+3YBzp8jawlCvu6//BAb2A+mgbRyg635qhEo2C5nRQ1tzjzet?=
 =?us-ascii?Q?TKtSwew/Ui1679+X7uanvQAtZKWiA/y0kpLUIl9zBmCPSYsR4Kb3Wco9zOtn?=
 =?us-ascii?Q?w+hcnmVZ?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b955be9-2bd8-4d60-27c0-08d8c246f774
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2999.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2021 22:08:53.1986
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h0nNa6zHyVTyrEvFWCdJ1zU2NW0BbYwUEzf5Ftu9ysWmm2hAwMebNUGIsP8i3bRfATYuK81BmjIkKx+NideA1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4559
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9876 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 spamscore=0
 adultscore=0 bulkscore=0 phishscore=0 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2101260110
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9876 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0
 lowpriorityscore=0 mlxlogscore=999 clxscore=1011 phishscore=0 bulkscore=0
 spamscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 impostorscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2101260110
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 26, 2021 at 02:54:01PM +1000, Nicholas Piggin wrote:
> vunmap will remove ptes.

Should there be some ASSERT after the vunmap to make sure that is the
case? 
> 
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: iommu@lists.linux-foundation.org
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
>  kernel/dma/remap.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/dma/remap.c b/kernel/dma/remap.c
> index 905c3fa005f1..b4526668072e 100644
> --- a/kernel/dma/remap.c
> +++ b/kernel/dma/remap.c
> @@ -66,6 +66,5 @@ void dma_common_free_remap(void *cpu_addr, size_t size)
>  		return;
>  	}
>  
> -	unmap_kernel_range((unsigned long)cpu_addr, PAGE_ALIGN(size));
>  	vunmap(cpu_addr);
>  }
> -- 
> 2.23.0
> 
> _______________________________________________
> iommu mailing list
> iommu@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/iommu