Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Bharat Kumar Gogada <bharatku@xilinx.com>
To:     Bjorn Helgaas <helgaas@kernel.org>
CC:     "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        Rob Herring <robh@kernel.org>
Subject: RE: [PATCH] PCI: xilinx-nwl: Enable coherenct PCIe traffic using CCI
Thread-Topic: [PATCH] PCI: xilinx-nwl: Enable coherenct PCIe traffic using CCI
Thread-Index: AQHW79waWBCZJOrJ4Ua2pJ5DbOkqmKoyRSyAgAirLKA=
Date:   Wed, 27 Jan 2021 05:03:12 +0000
Message-ID: <BYAPR02MB555964381D30E72FC79B4F7CA5BB9@BYAPR02MB5559.namprd02.prod.outlook.com>
References: <1611223156-8787-1-git-send-email-bharat.kumar.gogada@xilinx.com>
 <20210121162827.GA2658969@bjorn-Precision-5520>
In-Reply-To: <20210121162827.GA2658969@bjorn-Precision-5520>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 18234e23-b7e3-4851-552a-08d8c280d8ea
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2021 05:03:12.2734
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tf1JA3Fge3HkxCnp3vq4jWDmOycjbYVsvJsGcIjqfZqSnw0yhCfnknC7cYdNxrc8esuUR7thjFAuMD5YLTRNZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB5125
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> [+cc Rob]
>=20
> s/coherenct/coherent/ in subject
> s/traffic/DMA/ (this applies specifically to DMA, not to MMIO)
>=20
> On Thu, Jan 21, 2021 at 03:29:16PM +0530, Bharat Kumar Gogada wrote:
> > - Add support for routing PCIe traffic coherently when  Cache Coherent
> > Interconnect(CCI) is enabled in the system.
>=20
> s/- Add/Add/
> s/Interconnect(CCI)/Interconnect (CCI)/
>=20
Thanks Bjorn for corrections.
Here is the CCI spec=20
https://developer.arm.com/documentation/ddi0470/k/preface

> Can you include a URL to a CCI spec?  I'm not familiar with it.  I guess =
this is
> something upstream from the host bridge, i.e., between the CPU and the
> host bridge, so it's outside the PCI domain?
>=20
> I'd like to mention the DT "dma-coherent" property in the commit log to
> help connect this with the knob that controls it.
Yes will add it.=20
>=20
> The "dma-coherent" property is mentioned several places in
> Documentation/devicetree/bindings/pci/ (but not anything obviously relate=
d
> to xilinx-nwl).  Should it be moved to something like
> Documentation/devicetree/bindings/pci/pci.txt to make it more generic?
>=20
I will update this property in documentation as optional property.
Rob can confirm if this can be moved to generic.=20
> > Signed-off-by: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>
> > ---
> >  drivers/pci/controller/pcie-xilinx-nwl.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/pci/controller/pcie-xilinx-nwl.c
> > b/drivers/pci/controller/pcie-xilinx-nwl.c
> > index 07e3666..08e06057 100644
> > --- a/drivers/pci/controller/pcie-xilinx-nwl.c
> > +++ b/drivers/pci/controller/pcie-xilinx-nwl.c
> > @@ -26,6 +26,7 @@
> >
> >  /* Bridge core config registers */
> >  #define BRCFG_PCIE_RX0			0x00000000
> > +#define BRCFG_PCIE_RX1			0x00000004
> >  #define BRCFG_INTERRUPT			0x00000010
> >  #define BRCFG_PCIE_RX_MSG_FILTER	0x00000020
> >
> > @@ -128,6 +129,7 @@
> >  #define NWL_ECAM_VALUE_DEFAULT		12
> >
> >  #define CFG_DMA_REG_BAR			GENMASK(2, 0)
> > +#define CFG_PCIE_CACHE			GENMASK(7, 0)
> >
> >  #define INT_PCI_MSI_NR			(2 * 32)
> >
> > @@ -675,6 +677,12 @@ static int nwl_pcie_bridge_init(struct nwl_pcie
> *pcie)
> >  	nwl_bridge_writel(pcie, CFG_ENABLE_MSG_FILTER_MASK,
> >  			  BRCFG_PCIE_RX_MSG_FILTER);
> >
> > +	/* This routes the PCIe DMA traffic to go through CCI path */
> > +	if (of_dma_is_coherent(dev->of_node)) {
> > +		nwl_bridge_writel(pcie, nwl_bridge_readl(pcie,
> BRCFG_PCIE_RX1) |
> > +				  CFG_PCIE_CACHE, BRCFG_PCIE_RX1);
> > +	}
> > +
> >  	err =3D nwl_wait_for_link(pcie);
> >  	if (err)
> >  		return err;
> > --
> > 2.7.4
> >