Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp513266pxb; Wed, 27 Jan 2021 13:31:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJzFD2tVjz1YCqHehnkQZ3JiKHyjO9xSxwsgKDHupipX/h9N3fRn0AErDj6+f/lmX4oXCbbY X-Received: by 2002:a17:906:2454:: with SMTP id a20mr8233074ejb.203.1611783071135; Wed, 27 Jan 2021 13:31:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611783071; cv=none; d=google.com; s=arc-20160816; b=F2WYJJIlicyhIa7oqWFO0Q0wAICmn9gTa4cVDNxT69Kd3AicTNm66PkUpvJpbAkyt8 CBGZppIIBMWTKcoppvH9oKIDOrv56Tgjk0iWJDBXfAYr75Jwbn6hoG7YI+kKNh8Qxm+5 hUn7mqGQw0+Amn/F3yVDJAjvUSYzzeEJDGyjrKgrsqaScmr3QK3hLgitZdjEhyyesXSh rB5SZC23Hf/vlPpEwi0OQG7h3N1n+I42tQjgloX72LzIh4YBtiC5bxoJxtTJpQBMaDPu Gvtws/H+qUMYR29XqGyOoVUNwtOv970+Hk0vLtfkJzZ7ymNhR7XO98oRy81Qh8popzrJ xQBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=CqKgGiA31ji91JUfrA7K3WTvBvHQ8ukOtwEdhs1EEDw=; b=lwLuIRznsGH/u8KgnwkLRfo+8RepOFDg2YxsNAi7XiWpcCGQzoAC5DTrflhRbGaCjM iYxEEFN1QcJbuVOEAn8drCh+ip5rwMzq+LO4bmYSRfvAUtOvrboeXbjtnXmPWClPZ8ml dsGQdZse7ERyd+eudeYQwvBzei8rUUgI5egAX2JEPUzA+obz7n4DmvVaAkfVyQlwjEPV fp9KzSntk4pD2NaImx1AwhUwYegw2C/fie3W+01gzt7KTWkefu6DFrs+HBkswA61qEME g8vBv2SxScHIg6Ha4PWJ7q/sHQH5Cr14ls2wr6HBBIjevQtt6tC+93vz+1GpcWkR6mB1 URZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=FRJllVEc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e8si1626191edn.494.2021.01.27.13.30.44; Wed, 27 Jan 2021 13:31:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=FRJllVEc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232018AbhA0GxI (ORCPT + 99 others); Wed, 27 Jan 2021 01:53:08 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:48730 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231718AbhA0Guq (ORCPT ); Wed, 27 Jan 2021 01:50:46 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 10R6YkXW057541; Wed, 27 Jan 2021 06:49:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=CqKgGiA31ji91JUfrA7K3WTvBvHQ8ukOtwEdhs1EEDw=; b=FRJllVEcgIeqK8IzvXV0Zyx1WAscgHQdYzfmIxOi7hF8n2wHMiWU7m0itnt2bfVtwED8 c1KE/NPGCgCyMtXTmAdlKwSmyJa6QbJDS3xfNBxk1DM46Rg50PZErobGDj3MDqjs/N+3 L5c4FK18i13s28KUwKi56p9+VJmzfTiSFV0UX8DeAaAEv5+bKzrE61BLDYNV8LvzDUeH T+bq6ymxU2X9z3s7vJjeWFFxfRf3SDP+OPpgpgtQt1gWz/JSw62xuvzFz7Wf0IUrn42Q zr/L1FD0K8m77AZ2NWQOcqzjqMu+l5qWTnO7r2TjENzBZtyrBYzssSndJiP8TUUgp3Hk 0Q== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 368brkndkq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Jan 2021 06:49:37 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 10R6Z6EP099786; Wed, 27 Jan 2021 06:49:35 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 368wcnvup1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Jan 2021 06:49:35 +0000 Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 10R6nP7f003592; Wed, 27 Jan 2021 06:49:25 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 26 Jan 2021 22:49:24 -0800 Date: Wed, 27 Jan 2021 09:49:16 +0300 From: Dan Carpenter To: carlis Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, mh12gx2825@gmail.com, gregkh@linuxfoundation.org, oliver.graute@kococonnector.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, sbrivio@redhat.com, colin.king@canonical.com, zhangxuezhi1@yulong.com Subject: Re: [PATCH v5] fbtft: add tearing signal detect Message-ID: <20210127064916.GD2696@kadam> References: <1611711140-68260-1-git-send-email-zhangxuezhi3@gmail.com> <20210127054523.GA2696@kadam> <20210127141927.00004472@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210127141927.00004472@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9876 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 suspectscore=0 phishscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101270037 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9876 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 impostorscore=0 phishscore=0 bulkscore=0 priorityscore=1501 mlxlogscore=999 lowpriorityscore=0 spamscore=0 mlxscore=0 suspectscore=0 malwarescore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101270037 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 27, 2021 at 02:19:27PM +0800, carlis wrote: > hi,i will fix it like below: > par->gpio.te = devm_gpiod_get_index_optional(dev, "te", 0, > GPIOD_IN); if (IS_ERR(par->gpio.te)) { > rc = PTR_ERR(par->gpio.te); > pr_err("Failed to request te gpio: %d\n", rc); > par->gpio.te = NULL; > } I wish you would just copy and paste the code that I sent you instead, but this also fixes the crash... regards, dan carpenter