Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp513788pxb; Wed, 27 Jan 2021 13:32:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJzvemAcQrQpRUEbWjt2zpCyIW2DSgK/u1uPMEqtQnEvsnKN+jXOmMuj1v8qRquO5oOclqYO X-Received: by 2002:a17:906:1a0c:: with SMTP id i12mr8572873ejf.325.1611783129343; Wed, 27 Jan 2021 13:32:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611783129; cv=none; d=google.com; s=arc-20160816; b=Ch15n1cz9C/m65yRDPiKkI30eQkyPhkZIMIKPGZsaGw1sBIqBoCytaDnkuk6+ZfHBF 5tM0Qrcc7g5CGbZnZQKPPoSYy6uxxpypHIOw5NN5P7lEZkeONFRf2XtW3OEavrce3A0+ PnXgBkGiYWdqYBXH9Sw44oiPY/lgRItXOnTLmSX4zz5z6VS5vA5QWR1F+7AXKQDzJM63 muBNJtmHNx2URZBbHx9h7Sn+Jqo2WsKl8cX3OJZ5kLeTvYmYQc4uWXDig+pR+X5/LYNK Umt9BRdIaDQ7eat3RnmhKv6UmFgxy59t3JRAovyHmubFGhSaB27DTgWLWxXtMSnWGM1Q 4PTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=ednJG7kt8iV0LFaTKZiqO/lCe6Bv86GuZ0I9cD9PorQ=; b=uBU/EM0YzTgKLDAgnMVIPmKFgLi2iBo1/CpSCg9seCQupFSBbp0QC+mTSV1IhWCV7e wzC1TrlAvhNbPdPa7B07XlgkejAXqU6tNsW1uahiR5QVEDf6lDoctiAp82f0K7DBb1/k P3E/ZMo8lTBjNZ7GKMy35HoZYta/r+icQzWAuTFZHz6KFXLHkr0XC3CFpP6IjvAH1p92 9OudXMKN5xQfPBzJInWxkp+i8iYlSHA9+gsOF9Derm5v5wQHWQ08GiHeMP5cctzZriKS jl/601Yd/2caqhQG+rVNRMYHxokW83kulcit5Tg3q9k+/c/i7GuGHa1WmO1q/wiQmwS2 bPuw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hr15si1317380ejc.287.2021.01.27.13.31.41; Wed, 27 Jan 2021 13:32:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233759AbhA0HUB (ORCPT + 99 others); Wed, 27 Jan 2021 02:20:01 -0500 Received: from verein.lst.de ([213.95.11.211]:51659 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233087AbhA0HLn (ORCPT ); Wed, 27 Jan 2021 02:11:43 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 8FBA767373; Wed, 27 Jan 2021 08:10:59 +0100 (CET) Date: Wed, 27 Jan 2021 08:10:59 +0100 From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Nicholas Piggin , linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Robin Murphy , Christoph Hellwig Subject: Re: [PATCH 2/5] kernel/dma: remove unnecessary unmap_kernel_range Message-ID: <20210127071059.GA21133@lst.de> References: <20210126045404.2492588-1-npiggin@gmail.com> <20210126045404.2492588-3-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2021 at 05:08:46PM -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Jan 26, 2021 at 02:54:01PM +1000, Nicholas Piggin wrote: > > vunmap will remove ptes. > > Should there be some ASSERT after the vunmap to make sure that is the > case? Not really. removing the PTEs is the whole point of vunmap. Everything else is just house keeping.