Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp517163pxb; Wed, 27 Jan 2021 13:38:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJzzsNC101JbMGdcrBMc/Vo754YqPmIX30CGP7mkT9jaoQHvuoRPVUvQ7Wy553ndFbxpXVnc X-Received: by 2002:a17:906:49c2:: with SMTP id w2mr7935774ejv.12.1611783499422; Wed, 27 Jan 2021 13:38:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611783499; cv=none; d=google.com; s=arc-20160816; b=veENsqMSoJ2hCxDRBh1F0hjG5KWbiV0YkOTelAOMXfYjhTq5pWNvhkzVqaJLz1MKv2 j1smOqopO32NTKDX452Y4x1fgKFlxHETc6nP7SvSKM3oEh4ZKkWMuJD0FTVQ5f77hbzA QoP9HYeWkSJ7IwuDL81WYFTnx5MG2DZsKL9EQvxKDPS7QzbmcHe07IvswPJc+FRII57o m5EdwMKVNM0b4QE13Nki5cPA+UL4QSwhbtw3FANhgaXQouy/rUUP+zyUur9rm4490dsc DKlDH5gmSz/nqM5zorRPfX/jKbO8AcalxwlQsHQDUqaEkkBtZgMSInlqUxAmp4EauFYK R3ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :sender:dkim-signature; bh=960hhNTG56+qX20fkyX8J9sKQsVs3STq7WvHt5UIqf8=; b=wd8fL4q25I5IGybqQFN98E4ynmOUyzLEE/nSzjoYuEjAVXlu1O4m+igLjAdR+dSM67 Pybh57YCOZ9hnOUPNBAJY5BwRlu+xmpamMUX5G06LaqQjbZVv7yAIRtNVZtuiduvFMEt eeNGebzcJSpaPTihqRvCaUS7+xcEUek0tdUs10gZgrcP4vOXsUIJCXdyTj9wGNQtZDe5 TCVUXBAvsS7zgnutYHXgXBAQSsthkIFuKW0fymR/Trm3Bpxlf6ScWSlHyfDDJvskxpBb MUCEmr+G60SmiBlEKDnvlYWTjEBGpo7UViHjikkEShtOFC8BNeZuqwseYSkuccYUXkut WPIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=xMgEbeIY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id um7si1334353ejb.425.2021.01.27.13.37.53; Wed, 27 Jan 2021 13:38:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=xMgEbeIY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229828AbhA0IQJ (ORCPT + 99 others); Wed, 27 Jan 2021 03:16:09 -0500 Received: from m42-8.mailgun.net ([69.72.42.8]:55577 "EHLO m42-8.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234536AbhA0IMo (ORCPT ); Wed, 27 Jan 2021 03:12:44 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1611735114; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=960hhNTG56+qX20fkyX8J9sKQsVs3STq7WvHt5UIqf8=; b=xMgEbeIYOQ5y04jbmSCar2uaOq60GLPZ+jYZSBjMmWXOaNRySmtarJqwiJR3IVYL7pKodDZJ VAvLeim6zaqgTzIp8xyF7JQ/wRXI/U8S16Cn1ZYqCiF7h9uSw6GGe/7nunGuRx3EysHDl/9j BVZR23DASnW+1Ho9oTV/UT974AQ= X-Mailgun-Sending-Ip: 69.72.42.8 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 60111d6983c9d4cc539c9125 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 27 Jan 2021 07:59:37 GMT Sender: cang=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 3C403C43463; Wed, 27 Jan 2021 07:59:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id 90577C433CA; Wed, 27 Jan 2021 07:59:36 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 27 Jan 2021 15:59:36 +0800 From: Can Guo To: Avri Altman Cc: Asutosh Das , martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, stern@rowland.harvard.edu, "Bao D . Nguyen" , FUJITA Tomonori , Jens Axboe , "open list:BLOCK LAYER" , open list Subject: Re: [RFC PATCH v1 1/2] block: bsg: resume scsi device before accessing In-Reply-To: References: Message-ID: <75c66862d61c63fcfa61cd6dce254169@codeaurora.org> X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-01-27 15:09, Avri Altman wrote: >> >> Resumes the scsi device before accessing it. >> >> Change-Id: I2929af60f2a92c89704a582fcdb285d35b429fde >> Signed-off-by: Asutosh Das >> Signed-off-by: Can Guo >> Signed-off-by: Bao D. Nguyen > Following this patch, is it possible to revert commit 74e5e468b664d? > No, but this is a good finding... This change assumes that the queue->queue_data is a scsi_device, which is why we call scsi_auto_pm_get(). But for ufs_bsg's case, queue->queue_data is a device... Thanks, Can Guo. > Thanks, > Avri