Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp522749pxb; Wed, 27 Jan 2021 13:49:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJwMIu6j1/G6Rv8qwcvFnf5aSNtgYu22uJPC4LNANFYm7hyny78in9sJnS2ejT+FBpvlQ05J X-Received: by 2002:a17:906:2407:: with SMTP id z7mr8389481eja.219.1611784179994; Wed, 27 Jan 2021 13:49:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611784179; cv=none; d=google.com; s=arc-20160816; b=xJ6SU934FMQYAyzI+2ZoU9WKv03logLE0XbYDhbRvlXntvTint80ezJ9fzQGa/BIz/ mlIfS3NwpqHYhJVs+BPDTAwsJGyCszh5dLw6k3neO1wXkfxSHX70O8Ns/NQ2cOWyavPc YDljHE7wU1hzpiweRRXleU7c7xT9LJtiuObWToYx4RGPRYrO7H2CdtBay2S893+UEWx2 u+6/IFacOhcabhp+hiaA8ziaQePx144gVPRZIKvBQyAv04sheK42Ybq6/H2bFmIM9JET xe2PRk9fl07koFGppBIC0WBfL2Ihk8iqnu8xceu9t9InsST/AeQZ2y63vct+rl/C1/0C ssNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=CB4a6C1JnO4sl/4xhXQoy0RjFsU62F1Q9TQz/sO4dmA=; b=RW74NByFckj4cykKv341uU6l3qcb0w/tLSZdpF4d4w0qa0fWaLCkDAkJAKIC/JyhH+ 2dgx+lEx199xNJVF6qhKoZQLpxJjKE9MVjlSUNlSjYaB/gbav6eBtkpfsAIZVXb2A0Z+ SgZQ1mTW6BZVSM9KBsa1emWzmBSDBtk8CeUdOvcgZFxLAZV2A45QL0h1fKrps07q9MAO LbYWBv3JZdepH3gK1c20GRYiIcrZOPkgeacP1mS6B0qkTykjuvBe1/QKKg465DFhhu9Y 5lfN1hAZE/z7DhSh06IJo3jsJPiOLGU10WaLsNr/Uc3tqQcwE7pp7+AwUiz+YnWNGXHS HuZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v24si1649761edw.449.2021.01.27.13.49.15; Wed, 27 Jan 2021 13:49:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232136AbhA0Jf6 (ORCPT + 99 others); Wed, 27 Jan 2021 04:35:58 -0500 Received: from out30-42.freemail.mail.aliyun.com ([115.124.30.42]:43153 "EHLO out30-42.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235240AbhA0JdF (ORCPT ); Wed, 27 Jan 2021 04:33:05 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0UN2J2GL_1611739923; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UN2J2GL_1611739923) by smtp.aliyun-inc.com(127.0.0.1); Wed, 27 Jan 2021 17:32:10 +0800 From: Abaci Team To: axboe@kernel.dk Cc: minchan@kernel.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Abaci Team Subject: [PATCH] zram: remove redundant NULL check Date: Wed, 27 Jan 2021 17:32:02 +0800 Message-Id: <1611739922-3365-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix below warnings reported by coccicheck: ./drivers/block/zram/zram_drv.c:534:2-8: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot Suggested-by: Yang Li Signed-off-by: Abaci Team --- drivers/block/zram/zram_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index e2933cb..92739b9 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -530,8 +530,7 @@ static ssize_t backing_dev_store(struct device *dev, return len; out: - if (bitmap) - kvfree(bitmap); + kvfree(bitmap); if (bdev) blkdev_put(bdev, FMODE_READ | FMODE_WRITE | FMODE_EXCL); -- 1.8.3.1