Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Chenyi Qiang <chenyi.qiang@intel.com>,
        Thomas Huth <thuth@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        Xiaoyao Li <xiaoyao.li@intel.com>
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20201105081805.5674-1-chenyi.qiang@intel.com>
 <20201105081805.5674-9-chenyi.qiang@intel.com>
 <6174185b-25e0-f2a2-3f71-d8bbe6ca889d@redhat.com>
 <7aa67008-a72f-f6e3-2de4-4b9b9e62cd86@redhat.com>
 <e1ba2803-877c-e7d5-0a16-f356d5c2b571@intel.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [kvm-unit-tests PATCH] x86: Add tests for PKS
Message-ID: <ce0fad10-ddca-2102-0331-86ddcba9e808@redhat.com>
Date:   Wed, 27 Jan 2021 10:46:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <e1ba2803-877c-e7d5-0a16-f356d5c2b571@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 19/01/21 08:41, Chenyi Qiang wrote:
>>
> 
> Hi Paolo,
> 
> Thank you for your time. I was just thinking about resending this patch 
> series to ping you although no changes will be added. I really hope to 
> get the comments from you.
> 
> Do you want me to resend a new non-RFC version as well as the QEMU 
> implementation? or you review this RFC series first?
> 
> Thanks
> Chenyi

Hi,

I have reviewed the KVM implementation and actually I have also 
implemented PKRS in QEMU's binary translation.  I'll send a patch and 
commit this one too, since it can be tested.

For QEMU you'll still have to post the KVM parts (getting/setting the 
PKRS MSR) since I don't have a way to test those.

Paolo