Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Valentin Schneider <valentin.schneider@arm.com>
To:     Yue Hu <zbestahu@gmail.com>, thara.gopinath@linaro.org,
        peterz@infradead.org
Cc:     linux-kernel@vger.kernel.org, huyue2@yulong.com,
        zhangwen@yulong.com, zbestahu@163.com
Subject: Re: [PATCH] init/Kconfig: correct thermal pressure retrieve API
In-Reply-To: <20210127054451.1240-1-zbestahu@gmail.com>
References: <20210127054451.1240-1-zbestahu@gmail.com>
User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu)
Date:   Wed, 27 Jan 2021 10:48:49 +0000
Message-ID: <jhjr1m61wq6.mognet@arm.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On 27/01/21 13:44, Yue Hu wrote:
> From: Yue Hu <huyue2@yulong.com>
>
> We're using arch_scale_thermal_pressure() to retrieve per CPU thermal
> pressure.
>
> Signed-off-by: Yue Hu <huyue2@yulong.com>

Whoever wrote that clearly got "arch" and "topology" mixed up!

Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>

> ---
>  init/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index c4e0a7e..5b35e15 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -525,7 +525,7 @@ config SCHED_THERMAL_PRESSURE
>         i.e. put less load on throttled CPUs than on non/less throttled ones.
>
>         This requires the architecture to implement
> -	  arch_set_thermal_pressure() and arch_get_thermal_pressure().
> +	  arch_set_thermal_pressure() and arch_scale_thermal_pressure().
>
>  config BSD_PROCESS_ACCT
>       bool "BSD Process Accounting"
> --
> 1.9.1