Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Will Deacon <will@kernel.org>
To:     robin.murphy@arm.com, bjorn.andersson@linaro.org,
        "Isaac J. Manjarres" <isaacm@codeaurora.org>, joro@8bytes.org
Cc:     catalin.marinas@arm.com, kernel-team@android.com,
        Will Deacon <will@kernel.org>, linux-kernel@vger.kernel.org,
        iommu@lists.linux-foundation.org,
        linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH] iommu/arm-smmu-qcom: Fix mask extraction for bootloader programmed SMRs
Date:   Tue, 26 Jan 2021 22:35:41 +0000
Message-Id: <161167109569.3787430.13165422969483638185.b4-ty@kernel.org>
In-Reply-To: <1611611545-19055-1-git-send-email-isaacm@codeaurora.org>
References: <1611611545-19055-1-git-send-email-isaacm@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 25 Jan 2021 13:52:25 -0800, Isaac J. Manjarres wrote:
> When extracting the mask for a SMR that was programmed by the
> bootloader, the SMR's valid bit is also extracted and is treated
> as part of the mask, which is not correct. Consider the scenario
> where an SMMU master whose context is determined by a bootloader
> programmed SMR is removed (omitting parts of device/driver core):
> 
> ->iommu_release_device()
>  -> arm_smmu_release_device()
>   -> arm_smmu_master_free_smes()
>    -> arm_smmu_free_sme() /* Assume that the SME is now free */
>    -> arm_smmu_write_sme()
>     -> arm_smmu_write_smr() /* Construct SMR value using mask and SID */
> 
> [...]

Applied to will (for-joerg/arm-smmu/updates), thanks!

[1/1] iommu/arm-smmu-qcom: Fix mask extraction for bootloader programmed SMRs
      https://git.kernel.org/will/c/dead723e6f04

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev