Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp587261pxb; Wed, 27 Jan 2021 15:58:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJx+D45xbMEfyks4SVEchPS6h2uShhArb4wV8VxiHmnquP6KbchzrFoxnr56sOCqnSV/pw+D X-Received: by 2002:a17:906:c1c1:: with SMTP id bw1mr8903367ejb.86.1611791918802; Wed, 27 Jan 2021 15:58:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611791918; cv=none; d=google.com; s=arc-20160816; b=Gat9o6nmxhYkhwrB2Dyo8CBlBNJBLjtvZCxckJOWcvxNSOXGp9RN1ThDqvuxL9twTs bMLaUTHqdvhRMVm3CAcWPvQOifWp/y/VyAuAO/vX8Y41DEXvm88GdxHsFxl7HtThIikl 4U7E6YqfRKKeBoroqSjRD9Cc+dbC8o0H3+7TtkOmKWEhUHCUpA9KwkwBXXbYJ7mFHKDE DXT9Xdf7E5OS3zoD1qU16lfeJ9+unb5mIPtM+Y7MiKSpgJZj0W1j7lwvNvgXibIEOVFE qWyYMZiN1QsnTC1VhhtotYPhkZvzDwJdCBt/qlEoN2zVmA4wpVOObMQoRS9IZczrVyCj jzmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :mime-version:user-agent:date:message-id:autocrypt:subject:from:cc :to:dkim-signature; bh=2MI+NHy/r23ezsNgQtnaK6df8sAoa/lnTedXGUTkDLY=; b=hSDkE/aU/KHLi1tOiz0EijrCQRyld14kSrz4MJCXA/iliKFnJW76s6UpYS0BYl4p81 /jwSsEJvN/qKrQKEs2KokyuhrFGTBugOCwejOlA7c58NKxlOh63VnQW61Zc5ssruyI98 MCT2fN7eG1HvXoqjkWu2KQBBykKBUzdNyGQ+K/TyTYVqqjMHU3MXoY0JQnrigp2iar2G DjqDoL9iop2lQFOBWV8zX38Gm8HttVuklsoAgGf695W0TrXdIdSDtVqApvtuks2p3i28 LvHs4drtd1NS6Y52iDLT946Qj9jxk4fAOgTeznv04erGGhS1wzqpAlD+AWntz89W4khd Y4kw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=JNvFcjRh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e6si1952925edz.362.2021.01.27.15.58.14; Wed, 27 Jan 2021 15:58:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=JNvFcjRh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231163AbhA0NpL (ORCPT + 99 others); Wed, 27 Jan 2021 08:45:11 -0500 Received: from mx2.suse.de ([195.135.220.15]:58240 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231462AbhA0NoR (ORCPT ); Wed, 27 Jan 2021 08:44:17 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1611755010; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding:autocrypt:autocrypt; bh=2MI+NHy/r23ezsNgQtnaK6df8sAoa/lnTedXGUTkDLY=; b=JNvFcjRh7RRFG3WnLD8cIvU+mkjDAizE937+EJxIpO0T1I/QDlrfErrfB6nYLKSKk8ZpY+ tzX2dVhtOPqdiWauAlc5DikhDRTLgZSgv1joClhKuUTiTQlkYkvp1+Dkm9MGyuci+SOBIN tuyseO79gFO5yGKXgLkhOjYAfwWqI+k= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 069C8ABDA; Wed, 27 Jan 2021 13:43:30 +0000 (UTC) To: Peter Zijlstra , mhiramat@kernel.org Cc: LKML From: Nikolay Borisov Subject: kprobes broken since 0d00449c7a28 ("x86: Replace ist_enter() with nmi_enter()") Autocrypt: addr=nborisov@suse.com; prefer-encrypt=mutual; keydata= mQINBFiKBz4BEADNHZmqwhuN6EAzXj9SpPpH/nSSP8YgfwoOqwrP+JR4pIqRK0AWWeWCSwmZ T7g+RbfPFlmQp+EwFWOtABXlKC54zgSf+uulGwx5JAUFVUIRBmnHOYi/lUiE0yhpnb1KCA7f u/W+DkwGerXqhhe9TvQoGwgCKNfzFPZoM+gZrm+kWv03QLUCr210n4cwaCPJ0Nr9Z3c582xc bCUVbsjt7BN0CFa2BByulrx5xD9sDAYIqfLCcZetAqsTRGxM7LD0kh5WlKzOeAXj5r8DOrU2 GdZS33uKZI/kZJZVytSmZpswDsKhnGzRN1BANGP8sC+WD4eRXajOmNh2HL4P+meO1TlM3GLl EQd2shHFY0qjEo7wxKZI1RyZZ5AgJnSmehrPCyuIyVY210CbMaIKHUIsTqRgY5GaNME24w7h TyyVCy2qAM8fLJ4Vw5bycM/u5xfWm7gyTb9V1TkZ3o1MTrEsrcqFiRrBY94Rs0oQkZvunqia c+NprYSaOG1Cta14o94eMH271Kka/reEwSZkC7T+o9hZ4zi2CcLcY0DXj0qdId7vUKSJjEep c++s8ncFekh1MPhkOgNj8pk17OAESanmDwksmzh1j12lgA5lTFPrJeRNu6/isC2zyZhTwMWs k3LkcTa8ZXxh0RfWAqgx/ogKPk4ZxOXQEZetkEyTFghbRH2BIwARAQABtCNOaWtvbGF5IEJv cmlzb3YgPG5ib3Jpc292QHN1c2UuY29tPokCOAQTAQIAIgUCWIo48QIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQcb6CRuU/KFc0eg/9GLD3wTQz9iZHMFbjiqTCitD7B6dTLV1C ddZVlC8Hm/TophPts1bWZORAmYIihHHI1EIF19+bfIr46pvfTu0yFrJDLOADMDH+Ufzsfy2v HSqqWV/nOSWGXzh8bgg/ncLwrIdEwBQBN9SDS6aqsglagvwFD91UCg/TshLlRxD5BOnuzfzI Leyx2c6YmH7Oa1R4MX9Jo79SaKwdHt2yRN3SochVtxCyafDlZsE/efp21pMiaK1HoCOZTBp5 VzrIP85GATh18pN7YR9CuPxxN0V6IzT7IlhS4Jgj0NXh6vi1DlmKspr+FOevu4RVXqqcNTSS E2rycB2v6cttH21UUdu/0FtMBKh+rv8+yD49FxMYnTi1jwVzr208vDdRU2v7Ij/TxYt/v4O8 V+jNRKy5Fevca/1xroQBICXsNoFLr10X5IjmhAhqIH8Atpz/89ItS3+HWuE4BHB6RRLM0gy8 T7rN6ja+KegOGikp/VTwBlszhvfLhyoyjXI44Tf3oLSFM+8+qG3B7MNBHOt60CQlMkq0fGXd mm4xENl/SSeHsiomdveeq7cNGpHi6i6ntZK33XJLwvyf00PD7tip/GUj0Dic/ZUsoPSTF/mG EpuQiUZs8X2xjK/AS/l3wa4Kz2tlcOKSKpIpna7V1+CMNkNzaCOlbv7QwprAerKYywPCoOSC 7P25Ag0EWIoHPgEQAMiUqvRBZNvPvki34O/dcTodvLSyOmK/MMBDrzN8Cnk302XfnGlW/YAQ csMWISKKSpStc6tmD+2Y0z9WjyRqFr3EGfH1RXSv9Z1vmfPzU42jsdZn667UxrRcVQXUgoKg QYx055Q2FdUeaZSaivoIBD9WtJq/66UPXRRr4H/+Y5FaUZx+gWNGmBT6a0S/GQnHb9g3nonD jmDKGw+YO4P6aEMxyy3k9PstaoiyBXnzQASzdOi39BgWQuZfIQjN0aW+Dm8kOAfT5i/yk59h VV6v3NLHBjHVw9kHli3jwvsizIX9X2W8tb1SefaVxqvqO1132AO8V9CbE1DcVT8fzICvGi42 FoV/k0QOGwq+LmLf0t04Q0csEl+h69ZcqeBSQcIMm/Ir+NorfCr6HjrB6lW7giBkQl6hhomn l1mtDP6MTdbyYzEiBFcwQD4terc7S/8ELRRybWQHQp7sxQM/Lnuhs77MgY/e6c5AVWnMKd/z MKm4ru7A8+8gdHeydrRQSWDaVbfy3Hup0Ia76J9FaolnjB8YLUOJPdhI2vbvNCQ2ipxw3Y3c KhVIpGYqwdvFIiz0Fej7wnJICIrpJs/+XLQHyqcmERn3s/iWwBpeogrx2Lf8AGezqnv9woq7 OSoWlwXDJiUdaqPEB/HmGfqoRRN20jx+OOvuaBMPAPb+aKJyle8zABEBAAGJAh8EGAECAAkF AliKBz4CGwwACgkQcb6CRuU/KFdacg/+M3V3Ti9JYZEiIyVhqs+yHb6NMI1R0kkAmzsGQ1jU zSQUz9AVMR6T7v2fIETTT/f5Oout0+Hi9cY8uLpk8CWno9V9eR/B7Ifs2pAA8lh2nW43FFwp IDiSuDbH6oTLmiGCB206IvSuaQCp1fed8U6yuqGFcnf0ZpJm/sILG2ECdFK9RYnMIaeqlNQm iZicBY2lmlYFBEaMXHoy+K7nbOuizPWdUKoKHq+tmZ3iA+qL5s6Qlm4trH28/fPpFuOmgP8P K+7LpYLNSl1oQUr+WlqilPAuLcCo5Vdl7M7VFLMq4xxY/dY99aZx0ZJQYFx0w/6UkbDdFLzN upT7NIN68lZRucImffiWyN7CjH23X3Tni8bS9ubo7OON68NbPz1YIaYaHmnVQCjDyDXkQoKC R82Vf9mf5slj0Vlpf+/Wpsv/TH8X32ajva37oEQTkWNMsDxyw3aPSps6MaMafcN7k60y2Wk/ TCiLsRHFfMHFY6/lq/c0ZdOsGjgpIK0G0z6et9YU6MaPuKwNY4kBdjPNBwHreucrQVUdqRRm RcxmGC6ohvpqVGfhT48ZPZKZEWM+tZky0mO7bhZYxMXyVjBn4EoNTsXy1et9Y1dU3HVJ8fod 5UqrNrzIQFbdeM0/JqSLrtlTcXKJ7cYFa9ZM2AP7UIN9n1UWxq+OPY9YMOewVfYtL8M= Message-ID: <25cd2608-03c2-94b8-7760-9de9935fde64@suse.com> Date: Wed, 27 Jan 2021 15:43:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, I'm currently seeing latest Linus' master being somewhat broken w.r.t krpobes. In particular I have the following test-case: #!/bin/bash mkfs.btrfs -f /dev/vdc &> /dev/null mount /dev/vdc /media/scratch/ bpftrace -e 'kprobe:btrfs_sync_file {printf("kprobe: %s\n", kstack());}' &>bpf-output & bpf_trace_pid=$! # force btrfs_sync_file to be called sleep 2 xfs_io -f -c "pwrite 0 4m" -c "fsync" /media/scratch/file5 kill $bpf_trace_pid sleep 1 grep -q kprobe bpf-output retval=$? rm -f bpf-output umount /media/scratch exit $retval It traces btrfs_sync_file which is called when fsync is executed on a btrfs file, however I don't see the stacktrace being printed i.e the kprobe doesn't fire at all. The following alternative program: bpftrace -e 'tracepoint:btrfs:btrfs_sync_file {printf("tracepoint: %s\n", kstack());} kprobe:btrfs_sync_file {printf("kprobe: %s\n", kstack());}' only prints the stack from the tracepoint and not from the kprobe, given that the tracepoint is called from the btrfs_sync_file function. I started bisecting this and arrived at the following commit: 0d00449c7a28 ("x86: Replace ist_enter() with nmi_enter()") FWIW the following series is applied on the kernel I was testing: https://lore.kernel.org/lkml/159870598914.1229682.15230803449082078353.stgit@devnote2/ but it's still broken.