Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 27 Jan 2021 13:51:47 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Anshuman Khandual <anshuman.khandual@arm.com>
Cc:     linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
        mathieu.poirier@linaro.org, suzuki.poulose@arm.com,
        mike.leach@linaro.org, lcherian@marvell.com,
        linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com,
        mingo@redhat.com, will@kernel.org, mark.rutland@arm.com,
        acme@kernel.org, jolsa@redhat.com,
        Mathieu Poirier <mathieu.poirer@linaro.org>
Subject: Re: [PATCH V3 13/14] perf: aux: Add flags for the buffer format
Message-ID: <YBFh46OMgFW7FW2I@hirez.programming.kicks-ass.net>
References: <1611737738-1493-1-git-send-email-anshuman.khandual@arm.com>
 <1611737738-1493-14-git-send-email-anshuman.khandual@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1611737738-1493-14-git-send-email-anshuman.khandual@arm.com>
Precedence: bulk

On Wed, Jan 27, 2021 at 02:25:37PM +0530, Anshuman Khandual wrote:
> From: Suzuki K Poulose <suzuki.poulose@arm.com>
> 
> Allocate a byte for advertising the PMU specific format type
> of the given AUX record. A PMU could end up providing hardware
> trace data in multiple format in a single session.
> 
> e.g, The format of hardware buffer produced by CoreSight ETM
> PMU depends on the type of the "sink" device used for collection
> for an event (Traditional TMC-ETR/Bs with formatting or
> TRBEs without any formatting).

Acked-by: Peter Ziljstra <peterz@infradead.org>

> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
>  include/uapi/linux/perf_event.h | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
> index b15e344..9a5ca45 100644
> --- a/include/uapi/linux/perf_event.h
> +++ b/include/uapi/linux/perf_event.h
> @@ -1105,10 +1105,11 @@ enum perf_callchain_context {
>  /**
>   * PERF_RECORD_AUX::flags bits
>   */
> -#define PERF_AUX_FLAG_TRUNCATED		0x01	/* record was truncated to fit */
> -#define PERF_AUX_FLAG_OVERWRITE		0x02	/* snapshot from overwrite mode */
> -#define PERF_AUX_FLAG_PARTIAL		0x04	/* record contains gaps */
> -#define PERF_AUX_FLAG_COLLISION		0x08	/* sample collided with another */
> +#define PERF_AUX_FLAG_TRUNCATED			0x01	/* record was truncated to fit */
> +#define PERF_AUX_FLAG_OVERWRITE			0x02	/* snapshot from overwrite mode */
> +#define PERF_AUX_FLAG_PARTIAL			0x04	/* record contains gaps */
> +#define PERF_AUX_FLAG_COLLISION			0x08	/* sample collided with another */
> +#define PERF_AUX_FLAG_PMU_FORMAT_TYPE_MASK	0xff00	/* PMU specific trace format type */
>  
>  #define PERF_FLAG_FD_NO_GROUP		(1UL << 0)
>  #define PERF_FLAG_FD_OUTPUT		(1UL << 1)
> -- 
> 2.7.4
>