Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965641AbWIRKbg (ORCPT ); Mon, 18 Sep 2006 06:31:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965643AbWIRKbf (ORCPT ); Mon, 18 Sep 2006 06:31:35 -0400 Received: from mx1.redhat.com ([66.187.233.31]:63382 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S965641AbWIRKbf (ORCPT ); Mon, 18 Sep 2006 06:31:35 -0400 From: David Howells In-Reply-To: <20060918033431.GV3034@melbourne.sgi.com> References: <20060918033431.GV3034@melbourne.sgi.com> <4cdee5980dad9980ec8f.1158455371@turing.ams.sunysb.edu> To: David Chinner Cc: "Josef 'Jeff' Sipek" , linux-kernel@vger.kernel.org, xfs-masters@oss.sgi.com, akpm@osdl.org, dhowells@redhat.com Subject: Re: [PATCH 5 of 11] XFS: Use SEEK_{SET, CUR, END} instead of hardcoded values X-Mailer: MH-E 8.0; nmh 1.1; GNU Emacs 22.0.50 Date: Mon, 18 Sep 2006 11:30:35 +0100 Message-ID: <2442.1158575435@warthog.cambridge.redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 756 Lines: 25 David Chinner wrote: > The hard coded values used in xfs_change_file_space() are documented as part > of the API to the userspace functions that use this interface in xfsctl(3). Hmmm... that's a good point. I think you're right on this account, and so the comments in: case 0: /*SEEK_SET*/ break; case 1: /*SEEK_CUR*/ bf->l_start += offset; break; case 2: /*SEEK_END*/ bf->l_start += ip->i_d.di_size; break; should be stripped off as they are not exactly correct. David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/