Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp589239pxb; Wed, 27 Jan 2021 16:01:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJxzIKh9137lQnpeyOn7gTxq9oOyLZcPiEJ4aIyJDEFzFP6KajrkY/FKQ/kEmSkHlh71tWj3 X-Received: by 2002:a05:6402:254b:: with SMTP id l11mr11100915edb.202.1611792107135; Wed, 27 Jan 2021 16:01:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611792107; cv=none; d=google.com; s=arc-20160816; b=bOgZ702Ymm3bzl7DGl1cm90+auydBizWVtumO+yIk6abs/hHrevvw7OFxukFt0NTkJ CEgfUKHcFf1knYcMUrUVyrhHORxmvvvr1uGLK9x0/WS0VUWGeFxSHY0VEsz0Nxu3QYkG LZLV3pc+96Zr1VOYbtIaT1XGsnWVzpK7EQdtXQZbNZ6p/lICIpNn+kXkpz/XGxPti6g5 Jh7Eo5lTO2ILvKYEE4tvTJY6dJZzwiZrG58q3kS2ka5FLLQi09wltfEzpCCO8btSmZx+ aE+3e5Dn8seeXPBFVD6CNTVyFTA6SNZ05AqS+p8VYkFrQbR0e6WWzxNGIzzjZaDuUAgW Nagw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5puc/0hIFTR/LmlKO9rZl2N0mCyLw4vPgxkTBrm8WYE=; b=jhnZZqcmZwC8RnxulY0F5SWybRNc3S+0gCPvmbj1PhDua/Bu2Z1Y56RXtenEuIc4VV q2HlicBDN25OxhXr103IbvVZsQ/opQxgiVflB6pFQ96QX3nIxM95i71fTO1G5aY0NQZF 2XTHeCAUEOSzxAZ5FAfIzrgzSF4U7JaVPJ7jt4Lm+U0TP76bDPIfEeiF2t1DCd6EJ0DY 6Gh46jS3YMUIHUyZpTwOkAxJEybTbNCHNSUiH98LGj4Icde8CnASwKgA+p6qm7JpOaHl uLt/wJy+AA3l4bk3E9Fu+JOUF7Q0rt6+kZwTcAgKm5T5AHqiAicZWXqcNFoSUHR7Nd60 ML4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=W8+KGfUX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dm28si1753264edb.528.2021.01.27.16.01.23; Wed, 27 Jan 2021 16:01:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=W8+KGfUX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231202AbhA0OP7 (ORCPT + 99 others); Wed, 27 Jan 2021 09:15:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:40558 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233913AbhA0ONt (ORCPT ); Wed, 27 Jan 2021 09:13:49 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id DEF33207B3; Wed, 27 Jan 2021 14:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1611756788; bh=91+FckkF0XsQXE8G5xq3ONP86dhD26FJMlpOx+Kbuoo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W8+KGfUXGrGH4qYqQIY+nAVen4ZTYfKvnxOGcqhfoG913R+Gsx2EaPYD4gSiGHbVS xtLwgaMKy3EYdYI5fAnnB+fO4QG2DeNVFxoPEvxxAjmOROjfzQNVZb25FubocBNStR 321EdMt8sT45bFDyXKL2xSyXmY1vCM+SIw8av3X0= Date: Wed, 27 Jan 2021 15:13:05 +0100 From: Greg KH To: carlis Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, mh12gx2825@gmail.com, oliver.graute@kococonnector.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, sbrivio@redhat.com, colin.king@canonical.com, zhangxuezhi1@yulong.com Subject: Re: [PATCH v10] staging: fbtft: add tearing signal detect Message-ID: References: <1611754972-151016-1-git-send-email-zhangxuezhi3@gmail.com> <20210127220809.000026fb@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210127220809.000026fb@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 27, 2021 at 10:08:09PM +0800, carlis wrote: > On Wed, 27 Jan 2021 14:51:55 +0100 > Greg KH wrote: > > > On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote: > > > From: zhangxuezhi > > > > > > For st7789v ic,when we need continuous full screen refresh, it is > > > best to wait for the TE signal arrive to avoid screen tearing > > > > > > Signed-off-by: zhangxuezhi > > > > Please slow down and wait at least a day between patch submissions, > > there is no rush here. > > > > And also, ALWAYS run scripts/checkpatch.pl on your submissions, so > > that you don't have a maintainer asking you about basic problems, > > like are in this current patch :( > > > > thanks, > > > > greg k-h > > hi, > This is my first patch contribution to Linux, so some of the rules > are not very clear .In addition, I can confirm that before sending > patch, I check it with checkPatch.py every time.Thank you very much for > your help Please read Documentation/SubmittingPatches which has a link to the checklist and other documentation you should read. And I doubt you are running checkpatch on your submission, as there is obvious coding style issues in it. If so, please provide the output as it must be broken :( thanks, greg k-h