Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp594713pxb; Wed, 27 Jan 2021 16:10:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJzCNwzYi3+V7iWZtH/pWkTqxtRVN6foleAAqji5DOOp7fsq8vAumEcdQGy3eWRxh2GFX0Hr X-Received: by 2002:aa7:d9c3:: with SMTP id v3mr11079227eds.133.1611792624345; Wed, 27 Jan 2021 16:10:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611792624; cv=none; d=google.com; s=arc-20160816; b=zkARKK9ZDQb/yIWXxree9PDrrSJPh0hS3Ud8obgCNIA41kzUkz04T4cyaw+W6ft6zj rh1HN+mnVZXjo3OAnlY9DOM6YX6pwVfEYXG4yi/AZknEjx40cA5LgIHmHBL/TQpUYSD6 2VKLGAdXt1vPtpFPWupAvZcHaaCc6mdOiCOmzxkr3aaH/g7EthK7/AdFn8i28QticGgK 4C8ZlJavkYqb5JpxPAeFQcgwWoWFWlho0vut3D4lLZSFhq/zR2c/iZNFb3YAGPvmWQRV KRAmNCO1+F4BXTdYll0hKzVcovQKNcs3IeAnFPTVn6cSlA+z+oiEC4Slux5Lb7YUeudu e4oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=xPwTmZpZAOTUiVjpyTn7NpxXgbsZ8zrFn0BKvWTONVY=; b=yXuPqGvexf8fjnxEhVHtAqHF/VTvptjuqbDUqjxeeTki8RdZjTO2OVPqpDgK0/wnEo HfbAdrIMGOyiskLJJSgsolXjrkBoJ6Qye5BhgVqod4YHO0UkCRqgUCoILjbMvnlxIHOl nGE8QgCmtuWoTHXZ7ALSgsnxtSvEMQvS5K4vT097b+GavlY70WY7WNy+CE8+pspKB4sM aHNDritT6qP26zPDUHP403VsgLFoYikliOR8/fzHuGr++VlrV6hDuWyLNnYdUaaftOBg dDpe1Fpu7CC/Bw7gs5KImNgdrY8Ts8fsPzMmiE0FE4wlLS3aZxCOMIix2L5hpLiDUPyi OUiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gg14si1534125ejb.367.2021.01.27.16.10.00; Wed, 27 Jan 2021 16:10:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344122AbhA0SCl (ORCPT + 99 others); Wed, 27 Jan 2021 13:02:41 -0500 Received: from mail.v3.sk ([167.172.186.51]:48220 "EHLO shell.v3.sk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1344098AbhA0SCi (ORCPT ); Wed, 27 Jan 2021 13:02:38 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by zimbra.v3.sk (Postfix) with ESMTP id 0D0D8DF5E5; Wed, 27 Jan 2021 17:57:49 +0000 (UTC) Received: from shell.v3.sk ([127.0.0.1]) by localhost (zimbra.v3.sk [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id gvktt2hGF6tH; Wed, 27 Jan 2021 17:57:48 +0000 (UTC) Received: from localhost (localhost.localdomain [127.0.0.1]) by zimbra.v3.sk (Postfix) with ESMTP id 9A24FE0AE3; Wed, 27 Jan 2021 17:57:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at zimbra.v3.sk Received: from shell.v3.sk ([127.0.0.1]) by localhost (zimbra.v3.sk [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id hr2dETXlABTL; Wed, 27 Jan 2021 17:57:48 +0000 (UTC) Received: from localhost (unknown [109.183.109.54]) by zimbra.v3.sk (Postfix) with ESMTPSA id 5FC65DF5E5; Wed, 27 Jan 2021 17:57:48 +0000 (UTC) From: Lubomir Rintel To: Mauro Carvalho Chehab Cc: Sakari Ailus , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Lubomir Rintel , stable@vger.kernel.org Subject: [PATCH] media: marvell-ccic: power up the device on mclk enable Date: Wed, 27 Jan 2021 19:01:43 +0100 Message-Id: <20210127180143.43437-1-lkundrak@v3.sk> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Writing to REG_CLKCTRL with the power off causes a hang. Enable the device first. Cc: stable@vger.kernel.org # 5.10+ Signed-off-by: Lubomir Rintel --- drivers/media/platform/marvell-ccic/mcam-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c b/drivers/me= dia/platform/marvell-ccic/mcam-core.c index c012fd2e1d291..34266fba824f2 100644 --- a/drivers/media/platform/marvell-ccic/mcam-core.c +++ b/drivers/media/platform/marvell-ccic/mcam-core.c @@ -931,6 +931,7 @@ static int mclk_enable(struct clk_hw *hw) mclk_div =3D 2; } =20 + pm_runtime_get_sync(cam->dev); clk_enable(cam->clk[0]); mcam_reg_write(cam, REG_CLKCTRL, (mclk_src << 29) | mclk_div); mcam_ctlr_power_up(cam); @@ -944,6 +945,7 @@ static void mclk_disable(struct clk_hw *hw) =20 mcam_ctlr_power_down(cam); clk_disable(cam->clk[0]); + pm_runtime_put(cam->dev); } =20 static unsigned long mclk_recalc_rate(struct clk_hw *hw, --=20 2.29.2