Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp595833pxb; Wed, 27 Jan 2021 16:12:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJxNE/oJERzWc4Pb+GzTEqkr2uJXnmgBdohPWayYPK0hq7QjLzwMjCRk9AQRBEzUREe692Ey X-Received: by 2002:a05:6402:3582:: with SMTP id y2mr11405207edc.345.1611792750825; Wed, 27 Jan 2021 16:12:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611792750; cv=none; d=google.com; s=arc-20160816; b=zQGoisMTYUxvitIh0/8gqe8YcdEmlFJZ/kYIxqW+hJ1gaOSNh/Ne78rQJ4S2nY0z+a sq3Xy2DYwwbwDj/GqLQYDnyv+njeJLL5xkpmmOKGrdYqGkXotQrrs5oHTHgdhbwjOefj m3X9WnBlO+db350M/SfPjm81P1R1MVtQZyYJd9LzQAAbnpSe/PjhX5nSSVYPIYK12ui5 sVHnOW+/bvYZ3X+119yq/+8jmLEIKAV/R+lRoLIG/MFu5gATJbTlgMyPVIEefTmQ0rwA bv0oKVa6g1vYq+JlQPkqnU20F1yMGMau8S4bIOxasQzlSaqK+ioJYbws2HaLTSeU/D/1 pM0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=EHIvDmsj4Y5VIDXHlhxPxp3i77gwNlMY4UhYupe3QP4=; b=Uuy9L5yfQNCR+miRyLGHVzUmsY8WM1/MidazA6dqHrV/WV7TB4LS0ssY3h5CCszubi fr9EBG3dEDfSLd9v0/NdpdGWHgsCQV+jcGmhB+jHvqXIg6D69nd5M2dGRUD1xEpApNsP 8DlYaB1OjA1DM9EreU4WbAFIs7RxaQX2um6pi0iuGB6xcCwE0kfsmf30M1eVFQ6055pq Kk/v71OtVyQiT13L3cMCJU58a8xb5JnhUdtfZT+bwJTONyv+peNnb8Yd1tHZNzlCudE1 eLigkwhel2hgtXq3tDTNp2vBpFreJD/rxHZ7DThZFAJdC/d3mHXkNh0z4wk24WTWZDTM ZMrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=R0ugJu1h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lz2si1073229ejb.81.2021.01.27.16.12.06; Wed, 27 Jan 2021 16:12:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=R0ugJu1h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344127AbhA0SJp (ORCPT + 99 others); Wed, 27 Jan 2021 13:09:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343941AbhA0SJm (ORCPT ); Wed, 27 Jan 2021 13:09:42 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A163C061574; Wed, 27 Jan 2021 10:09:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EHIvDmsj4Y5VIDXHlhxPxp3i77gwNlMY4UhYupe3QP4=; b=R0ugJu1h3eJyjepFBkG9U0K1fI hLpulWsoEYjLJxERx17/6nHHdf1+BAl5rcl5hbYtam/zjkDf+2ibErfFJEpC9AWp85qY9jUM12vYj YcM1UP36QYVdTjhcy3LyHFJ5GIzqfvw/qu+szVBtIsdOM1+o2u9B11ihHWZcDa1bp6az2S5DUWOQv aQ6oYmSIYL7sZ+MZLULvhebRM2Yzby+dfAWwHGQmwg1H3CmRX34QFOwxpa5XBNx0OFU6Oh/ErH+x+ rrY2hCe4iTTtLc5+kM0sdrw6LNioErMN7a5z+1LjP88Z1eXWri352iN7nEfMt9lP0sl7tn8HuRWJP 4vMuYV0Q==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l4pFE-007Kc7-QW; Wed, 27 Jan 2021 18:08:47 +0000 Date: Wed, 27 Jan 2021 18:08:44 +0000 From: Christoph Hellwig To: Ray Chi Cc: balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kyletso@google.com Subject: Re: [PATCH] usb: dwc3: add EXPORT_SYMBOL_GPL for role init functions Message-ID: <20210127180844.GA1747134@infradead.org> References: <20210126094913.180945-1-raychi@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210126094913.180945-1-raychi@google.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2021 at 05:49:13PM +0800, Ray Chi wrote: > Currently, role init functions are used in dwc3 driver but > can't be called from kernel modules. > dwc3_host_init > dwc3_host_exit > dwc3_gadget_init > dwc3_gadget_exit > dwc3_event_buffers_setup > dwc3_event_buffers_cleanup > > If other kernel modules want to use these functions, it needs > EXPORT_SYMBOL_GPL() to get compile pass. What "other kernel modules" would want to use it an why? Please specify that in your patch, and only resend it togethe with the patches actually adding/modifying those modules.