Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1611684201-16262-1-git-send-email-george.kennedy@oracle.com> <YBG0glwiK1wyJTeN@Konrads-MacBook-Pro.local>
In-Reply-To: <YBG0glwiK1wyJTeN@Konrads-MacBook-Pro.local>
From:   Dmitry Vyukov <dvyukov@google.com>
Date:   Wed, 27 Jan 2021 19:48:08 +0100
Message-ID: <CACT4Y+a48smtXc6qJy9Wthwuqjk2gh6o7BK1tfWW46g7D_r-Lg@mail.gmail.com>
Subject: Re: [PATCH 1/1] iscsi_ibft: KASAN false positive failure occurs in ibft_init()
To:     Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc:     George Kennedy <george.kennedy@oracle.com>,
        kasan-dev <kasan-dev@googlegroups.com>,
        Alexander Potapenko <glider@google.com>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>, pjones@redhat.com,
        konrad@kernel.org, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jan 27, 2021 at 7:44 PM Konrad Rzeszutek Wilk
<konrad.wilk@oracle.com> wrote:
>
> On Tue, Jan 26, 2021 at 01:03:21PM -0500, George Kennedy wrote:
> > During boot of kernel with CONFIG_KASAN the following KASAN false
> > positive failure will occur when ibft_init() reads the
> > ACPI iBFT table: BUG: KASAN: use-after-free in ibft_init
> >
> > The ACPI iBFT table is not allocated, and the iscsi driver uses
> > a pointer to it to calculate checksum, etc. KASAN complains
> > about this pointer with use-after-free, which this is not.
> >
>
> Andrey, Alexander, Dmitry,
>
> I think this is the right way for this, but was wondering if you have
> other suggestions?
>
> Thanks!

Hi George, Konrad,

Please provide a sample KASAN report and kernel version to match line numbers.

Why does KASAN think the address is freed? For that to happen that
memory should have been freed. I don't remember any similar false
positives from KASAN, so this looks a bit suspicious.


> > Signed-off-by: George Kennedy <george.kennedy@oracle.com>
> > ---
> >  drivers/firmware/Makefile | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/firmware/Makefile b/drivers/firmware/Makefile
> > index 5e013b6..30ddab5 100644
> > --- a/drivers/firmware/Makefile
> > +++ b/drivers/firmware/Makefile
> > @@ -14,6 +14,9 @@ obj-$(CONFIG_INTEL_STRATIX10_SERVICE) += stratix10-svc.o
> >  obj-$(CONFIG_INTEL_STRATIX10_RSU)     += stratix10-rsu.o
> >  obj-$(CONFIG_ISCSI_IBFT_FIND)        += iscsi_ibft_find.o
> >  obj-$(CONFIG_ISCSI_IBFT)     += iscsi_ibft.o
> > +KASAN_SANITIZE_iscsi_ibft.o := n
> > +KCOV_INSTRUMENT_iscsi_ibft.o := n
> > +
> >  obj-$(CONFIG_FIRMWARE_MEMMAP)        += memmap.o
> >  obj-$(CONFIG_RASPBERRYPI_FIRMWARE) += raspberrypi.o
> >  obj-$(CONFIG_FW_CFG_SYSFS)   += qemu_fw_cfg.o
> > --
> > 1.8.3.1
> >