Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
To:     Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
CC:     Nilesh Javali <njavali@marvell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Martin Petersen <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: qla2xxx: Simplify the calculation of variables
Thread-Topic: [PATCH] scsi: qla2xxx: Simplify the calculation of variables
Thread-Index: AQHW9AeX2TRd5K8GiUSNNvRxrb08UKo75leA
Date:   Wed, 27 Jan 2021 20:01:31 +0000
Message-ID: <FA227E6E-536F-4C00-9BB1-7346EBDA2F7A@oracle.com>
References: <1611650554-33019-1-git-send-email-abaci-bugfix@linux.alibaba.com>
In-Reply-To: <1611650554-33019-1-git-send-email-abaci-bugfix@linux.alibaba.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3B310DA6B45DDB4DA9BC4379FCE09972@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 06b690d6-fb28-4887-2d20-08d8c2fe5823
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2021 20:01:31.6504
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OrxwIYtSrdgcPaPDlGNeJt6wN4NmP83QDxXejgitQT/3RRo90ohCtpeSnK6MDtVLEctsZ9a9lxr6oJV/AsPYUhoXAbECqT6BKsWBRJshULk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB3022
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9877 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 spamscore=0
 adultscore=0 bulkscore=0 phishscore=0 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2101270100
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9877 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0
 lowpriorityscore=0 mlxlogscore=999 clxscore=1015 phishscore=0 bulkscore=0
 spamscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 impostorscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2101270099
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jan 26, 2021, at 2:42 AM, Jiapeng Zhong <abaci-bugfix@linux.alibaba.co=
m> wrote:
>=20
> Fix the following coccicheck warnings:
>=20
> ./drivers/scsi/qla2xxx/qla_nvme.c:288:24-26: WARNING !A || A && B is
> equivalent to !A || B.
>=20
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
> ---
> drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_n=
vme.c
> index eab559b..38196b2 100644
> --- a/drivers/scsi/qla2xxx/qla_nvme.c
> +++ b/drivers/scsi/qla2xxx/qla_nvme.c
> @@ -285,7 +285,7 @@ static int qla_nvme_ls_req(struct nvme_fc_local_port =
*lport,
> 	srb_t           *sp;
>=20
>=20
> -	if (!fcport || (fcport && fcport->deleted))
> +	if (!fcport || fcport->deleted)
> 		return rval;
>=20
> 	vha =3D fcport->vha;
> --=20
> 1.8.3.1
>=20

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering