Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: gILY+FR+rgrNNNCd6NY7EPGpxUTA/LaJlDxXURjZh9EdwoTc+YNxtIU84nKNDiK80tIgQbLFgc
 rSlxurCV8+sqqNr+SGryBexwgFFrABwviVFvW2N0IstDM7QReYfDFTvHhFGKJtyJ+7tn+o4Fx7
 tXihtJoKPBhodib2vy5y/q3aGg2eoN4/FiOVUQZb6wKoN67T9KfnfF2D3esNEyu4/sRBEMf+YI
 0HF/pKIg+S/4RKd5FQ/PYR3O/nzaVrK88iT+5DMoQJ+CKfKBKlU82INh7rdCvBXtLfpYa4bjZI
 SBw=
IronPort-SDR: uEgvNnH5D4PNOipI8Jx+YoldOUUYINQRNdTwMPU8AqsmQ0fiUOnw9hPL23e6+ZjQgnoG1D9QP4
 TF1iwjz3oBlNlNSBzkKJq+fWkKTaPnAFQcMTnBEu+stnoSQHhg9en8TAtyImVtT6zc1TH9UA9V
 Gr73OK6KP+wHWR1hgbNFjZzy6hHqHnCQMFzb61hrnGDjpjSXE1ZtpTeejvYY60krOhU/4B4H2i
 74pEuQHNBZ+z1Ml6R2IAbl99oPzYIu6bxLUX5/VmUrZoNq5mBOU+ZxrTAmqjpWfEjMQQCQ+lR/
 BBJo94EF80X3HIlZX2Tuahq5
IronPort-SDR: GvN6qUNehbBvrQk0sRqJWbPO5Gqmx3Eo3ItD4IXdUQzJKG8nPPx6hf0w3qem1FEw2nOhcUhDXh
 /4ppPfxyxp5dVdJ31YdKaCSMCwOJkqu5hPa8Ko+ujwkaGlHCtrUgp/snTWlTrp9RG32nmlKVOG
 Sawe5kRU0ulbdoqL+p/O5pd8svPsNOp9t79V6HyzSHa2VUsS8dRlUNqsky9JJG7FqPNfhacQhA
 bsNm0z6n20UFWLh0xTl7UgE2gIjvG/Q0E+AnCwlKkYyux30eqX6DmW4mWU4fn+sEFHXGn8LyDc
 Nx0=
WDCIronportException: Internal
From:   Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
To:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     axboe@kernel.dk, Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Subject: [COMPILE ONLY RFC PATCH] loop: avoid page allocation in the fast path
Date:   Wed, 27 Jan 2021 14:08:15 -0800
Message-Id: <20210127220815.57624-1-chaitanya.kulkarni@wdc.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

The functions lo_write_transfer() and lo_read_transfer() allocte and
free the page everytime it is called from the do_req_filebacked().

Add a member to the loop_cmd structure and use that page in read/write
transfer functions.

This is *compile only* RFC, if this is accepted I'll send tested
version.

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
 drivers/block/loop.c | 22 ++++++++--------------
 drivers/block/loop.h |  1 +
 2 files changed, 9 insertions(+), 14 deletions(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 578fc034db3f..08bd17afbdff 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -318,14 +318,13 @@ static int lo_write_simple(struct loop_device *lo, struct request *rq,
  * access to the destination pages of the backing file.
  */
 static int lo_write_transfer(struct loop_device *lo, struct request *rq,
-		loff_t pos)
+			     struct loop_cmd *cmd, loff_t pos)
 {
-	struct bio_vec bvec, b;
+	struct page *page = &cmd->page;
 	struct req_iterator iter;
-	struct page *page;
+	struct bio_vec bvec, b;
 	int ret = 0;
 
-	page = alloc_page(GFP_NOIO);
 	if (unlikely(!page))
 		return -ENOMEM;
 
@@ -343,7 +342,6 @@ static int lo_write_transfer(struct loop_device *lo, struct request *rq,
 			break;
 	}
 
-	__free_page(page);
 	return ret;
 }
 
@@ -377,19 +375,15 @@ static int lo_read_simple(struct loop_device *lo, struct request *rq,
 }
 
 static int lo_read_transfer(struct loop_device *lo, struct request *rq,
-		loff_t pos)
+		struct loop_cmd *cmd, loff_t pos)
 {
-	struct bio_vec bvec, b;
+	struct page *page = &cmd->page;
 	struct req_iterator iter;
+	struct bio_vec bvec, b;
 	struct iov_iter i;
-	struct page *page;
 	ssize_t len;
 	int ret = 0;
 
-	page = alloc_page(GFP_NOIO);
-	if (unlikely(!page))
-		return -ENOMEM;
-
 	rq_for_each_segment(bvec, rq, iter) {
 		loff_t offset = pos;
 
@@ -622,14 +616,14 @@ static int do_req_filebacked(struct loop_device *lo, struct request *rq)
 		return lo_fallocate(lo, rq, pos, FALLOC_FL_PUNCH_HOLE);
 	case REQ_OP_WRITE:
 		if (lo->transfer)
-			return lo_write_transfer(lo, rq, pos);
+			return lo_write_transfer(lo, rq, cmd, pos);
 		else if (cmd->use_aio)
 			return lo_rw_aio(lo, cmd, pos, WRITE);
 		else
 			return lo_write_simple(lo, rq, pos);
 	case REQ_OP_READ:
 		if (lo->transfer)
-			return lo_read_transfer(lo, rq, pos);
+			return lo_read_transfer(lo, rq, cmd, pos);
 		else if (cmd->use_aio)
 			return lo_rw_aio(lo, cmd, pos, READ);
 		else
diff --git a/drivers/block/loop.h b/drivers/block/loop.h
index a3c04f310672..dd949b22e9c9 100644
--- a/drivers/block/loop.h
+++ b/drivers/block/loop.h
@@ -71,6 +71,7 @@ struct loop_cmd {
 	atomic_t ref; /* only for aio */
 	long ret;
 	struct kiocb iocb;
+	struct page page;
 	struct bio_vec *bvec;
 	struct cgroup_subsys_state *css;
 };
-- 
2.22.1