Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp611385pxb; Wed, 27 Jan 2021 16:43:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJydizEBLz5y6FMjEnuCpcGfmG9UEBzEPkusKs80lcrMq1O2A9nwqWPo8T0sDmTE+3Cm5dsd X-Received: by 2002:a17:906:248e:: with SMTP id e14mr8773721ejb.495.1611794631390; Wed, 27 Jan 2021 16:43:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611794631; cv=none; d=google.com; s=arc-20160816; b=VruC+3a9GP11LalQWImF4YxUplBMD8wdHjRqt9xOPsF3mujU3WviWZ4J6N7g6+P5lD PA4MwF6BScKkyKJGM9+OrtCBOGXc0U3SMs/qIaPsdEpFo4fv/e8ghcuHWwtiykvL7NUW UA4asspQbb01SKfTQxaWa8SKk25k0QOJyQm2dJMiku3MnwGpGYajvkfvWnurKW6mRYQs d06IIYD+7RLkjxlel94Jy9RrkA3Zo0WTd2oT5k7ylK6gEbKW2hoxknmAQ1SDA2TsrNLt FE8aBAXQ2vl2JTIj5WU61RGim0hqs8ZPUQsrxEybGgLrJv1TT9+if/A/ZsgrKFS6J659 PLqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=obs10bJiilT1cczDEN53dBtE/KMJsx1tcd6EAwze+MQ=; b=G4EIDVlVegjX0KQ0IyhI0KRiTSz2jVBkj0qKHdd8AZDwJGGHDzeSS5khg3hOW3GRz3 n/j35qnFVmrZoi5bLIoXNqzCPX2LB6YKrtBQyfyYBMfoWD+f7zcd2odcfSE4/YLvYCuo JVBcfuVetelpbCdYcaKZZE5Nx44OtMrIG1+Xffvr0C8YFR+ORP3CqVXV2LdYBXm/F6pL WEwdc8WTgsXRJ8cPk9KVZ7H9mvaMvgV6uFTxjAskayG/4Yl1AhlcItIjz77+AZlv+z5W jJwDyGiHRcj4ppiMDl5+TpDygolsPm/bZ/EEQz0V7mZ98K1eG24TiZAHT9W8kWmpJUWY dzng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p5si623868ejo.398.2021.01.27.16.43.27; Wed, 27 Jan 2021 16:43:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236953AbhA0WQK (ORCPT + 99 others); Wed, 27 Jan 2021 17:16:10 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:37418 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231153AbhA0WQD (ORCPT ); Wed, 27 Jan 2021 17:16:03 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 88E5B1C0B8E; Wed, 27 Jan 2021 23:15:05 +0100 (CET) Date: Wed, 27 Jan 2021 23:15:05 +0100 From: Pavel Machek To: Adrian Catangiu Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, gregkh@linuxfoundation.org, graf@amazon.com, arnd@arndb.de, ebiederm@xmission.com, rppt@kernel.org, 0x7f454c46@gmail.com, borntraeger@de.ibm.com, Jason@zx2c4.com, jannh@google.com, w@1wt.eu, colmmacc@amazon.com, luto@kernel.org, tytso@mit.edu, ebiggers@kernel.org, dwmw@amazon.co.uk, bonzini@gnu.org, sblbir@amazon.com, raduweis@amazon.com, corbet@lwn.net, mst@redhat.com, mhocko@kernel.org, rafael@kernel.org, mpe@ellerman.id.au, areber@redhat.com, ovzxemul@gmail.com, avagin@gmail.com, ptikhomirov@virtuozzo.com, gil@azul.com, asmehra@redhat.com, dgunigun@redhat.com, vijaysun@ca.ibm.com, oridgar@gmail.com, ghammer@redhat.com Subject: Re: [PATCH v4 1/2] drivers/misc: sysgenid: add system generation id driver Message-ID: <20210127221505.GB24799@amd> References: <1610453760-13812-1-git-send-email-acatan@amazon.com> <1610453760-13812-2-git-send-email-acatan@amazon.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qlTNgmc+xy1dBmNv" Content-Disposition: inline In-Reply-To: <1610453760-13812-2-git-send-email-acatan@amazon.com> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --qlTNgmc+xy1dBmNv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > - Solution >=20 > The System Generation ID is a simple concept meant to alleviate the > issue by providing a monotonically increasing u32 counter that changes > each time the VM or container is restored from a snapshot. I'd make it u64. But as people explained, this has race problems that may be impossible to solve? Best regards, Pavel =09 --=20 http://www.livejournal.com/~pavelmachek --qlTNgmc+xy1dBmNv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmAR5ekACgkQMOfwapXb+vIeRACdFFlEw9Qzjgj/nAuNJzxFeb2z 28wAoKXL22jBt2ohyVp9BgmFr64wldNZ =T3KQ -----END PGP SIGNATURE----- --qlTNgmc+xy1dBmNv--