Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 28 Jan 2021 08:17:52 +0900
From:   Stafford Horne <shorne@gmail.com>
To:     David Gow <davidgow@google.com>
Cc:     Pawel Czarnecki <pczarnecki@internships.antmicro.com>,
        Mateusz Holenko <mholenko@antmicro.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] soc: litex: Properly depend on HAS_IOMEM
Message-ID: <20210127231752.GX2002709@lianli.shorne-pla.net>
References: <20210127033603.1519127-1-davidgow@google.com>
 <20210127122712.GU2002709@lianli.shorne-pla.net>
 <CABVgOSkkRt5eZRrb8ia-0++0W8A4radZBWWry1P16=ZcAKLAuQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CABVgOSkkRt5eZRrb8ia-0++0W8A4radZBWWry1P16=ZcAKLAuQ@mail.gmail.com>
Precedence: bulk

On Thu, Jan 28, 2021 at 12:49:56AM +0800, David Gow wrote:
> On Wed, Jan 27, 2021 at 8:27 PM Stafford Horne <shorne@gmail.com> wrote:
> >
> > On Tue, Jan 26, 2021 at 07:36:04PM -0800, David Gow wrote:
> > > The LiteX SOC controller driver makes use of IOMEM functions like
> > > devm_platform_ioremap_resource(), which are only available if
> > > CONFIG_HAS_IOMEM is defined.
> > >
> > > This causes the driver not to be enable under make ARCH=um allyesconfig,
> > > even though it won't build.
> >
> > Is this wording correct?  I suspect it causes to driver TO BE enabled.
> >
> 
> Whoops! Yes: that should be "causes the driver to be enabled" -- sorry
> about that.
> 
> Let me know if you want me to re-send it with the fixed wording, or if
> you just want to fix that yourself.

OK, I'll fix it.

> > >
> > > By adding a dependency on HAS_IOMEM, the driver will not be enabled on
> > > architectures which don't support it.
> > >
> > > Fixes: 22447a99c97e ("drivers/soc/litex: add LiteX SoC Controller driver")
> > > Signed-off-by: David Gow <davidgow@google.com>a
> >
> > This looks ok to me.  I can queue it for 5.11 fixes, if you can help with the
> > wording above.
> 
> Thanks: that'd be great!

No problem.

-Stafford