Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp613720pxb; Wed, 27 Jan 2021 16:48:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJyhFhqrF5ErDCfdLne+/7twQFOZI54cc4WQC2fwLyLHfDnx+Dwjkb4shQBnvaxa5amVA3S2 X-Received: by 2002:a17:906:409:: with SMTP id d9mr8478955eja.70.1611794937535; Wed, 27 Jan 2021 16:48:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611794937; cv=none; d=google.com; s=arc-20160816; b=lpCOJ/3XC76wkJxzliSLaCtmISXqwRk3xtMuf+ndJgy7xj9Ayd4MDUvhkSRcKSzLzJ xB79AfCk00SG+a90KzzUF/ko+v19sbu0aOhJjO70OZht3O2oU8sZGYdmW7F4MWwPdIV6 XLrWxDUACm9/halXrSQp3BOjwECeIK+bRhaxiRmHpgme2BKeyLsI6aus+0mkAjK/1L8H iZwMKPOQ/97b2TjaJyl6R4r4UMU8FBuK1oeIGtFZ+c4NhgQJjiWJYjbuF9kPeCEe8fb2 NOfeNj3F9FTZipN0MYW32F/VOtp92AP/MOD5KVkOzuEi7Og8O9vkrMx7KVdM1PC8LMPJ hPRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=qyBHjmciojXQm9rLbeg0lBP82B3g5K6Tmn85KfOUIf8=; b=szRBq/1mu3De/qG3w4TP8MdqotBshMZ96WIQ4bLciSI5AqMrIVIOxgqWQBL1YSichu x8FMfAR6d0AnvBAyQrQNxVg9ecA2ynXxMOvfuUPclDza3GjjWjdfB3LN8eKE42/UrQef xdbU2mKq+7CX4799S9dQWQg2BEnfrgM5W9/t+YexSkcDM3vvz6B4zI7lmoEq03Z0SXCu 4Lx9hLREM6oyPLAmnX8tkcJnffMdpX3cYlpB8aAqZ+sm9Jasi4kavvwtrbYoBSWfGpZP Oo4lD/bg9vXt2F3N/ageyA2RchWliXXiODym12Ci/23+nhUIt3tO5pA4+PT0IFS+zXEl BfYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 24si2166776edv.406.2021.01.27.16.48.33; Wed, 27 Jan 2021 16:48:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233321AbhA0XoX (ORCPT + 99 others); Wed, 27 Jan 2021 18:44:23 -0500 Received: from mga04.intel.com ([192.55.52.120]:58189 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234953AbhA0Xls (ORCPT ); Wed, 27 Jan 2021 18:41:48 -0500 IronPort-SDR: vmSPGRdooW5i9Ji8WU4VKw/tUJbdjbQSiS8YgNhU1aMwPVIU3NHA/rWEudaPE3Vi0gojGzxIEn 5kz3ArDxWbsA== X-IronPort-AV: E=McAfee;i="6000,8403,9877"; a="177589244" X-IronPort-AV: E=Sophos;i="5.79,380,1602572400"; d="scan'208";a="177589244" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 15:41:05 -0800 IronPort-SDR: bYTQL4GKNVvPWz+Eotb7l/0afQZmlkb5Z96b99nUsiyRWV0DOyd0kfrpQcEs8GIbeaMkus8Qan cWTHVDE/Fabg== X-IronPort-AV: E=Sophos;i="5.79,380,1602572400"; d="scan'208";a="573430594" Received: from fyahyaei-mobl2.amr.corp.intel.com (HELO [10.209.48.126]) ([10.209.48.126]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 15:41:04 -0800 Subject: Re: [PATCH V3] x86/mm: Tracking linear mapping split events To: Saravanan D , x86@kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com References: <20210127225059.246646-1-saravanand@fb.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: Date: Wed, 27 Jan 2021 15:41:05 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210127225059.246646-1-saravanand@fb.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/27/21 2:50 PM, Saravanan D wrote: > +#if defined(__x86_64__) We don't use __x86_64__ in the kernel. This should be CONFIG_X86. > +#if defined(CONFIG_X86_64) || defined(CONFIG_X86_PAE) > + "direct_map_2M_splits", > +#else > + "direct_map_4M_splits", > +#endif > + "direct_map_1G_splits", > +#endif These #ifdefs are hideous, and repeated. I'd rather have no 32-bit support than expose us to this ugliness. Worst case, the 32-bit non-PAE folks (i.e. almost nobody in the world) can just live with seeing "2M" when the mappings are really 4M. Or, you *could* name these after the page table levels: direct_map_pmd_splits direct_map_pud_splits or the level from the bottom where the split occurred: direct_map_level2_splits direct_map_level3_splits That has the bonus of being usable on other architectures. Oh, and 1G splits aren't possible on non-PAE 32-bit. There are only 2 levels: 4M and 4k, which would make what you have above: > +#if defined(CONFIG_X86_64) || defined(CONFIG_X86_PAE) > + "direct_map_2M_splits", > + "direct_map_1G_splits", > +#else > + "direct_map_4M_splits", > +#endif I don't think there's ever a 1G/4M case.