Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp615188pxb; Wed, 27 Jan 2021 16:52:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJxh0FV2l2HnKE3AkR/cr/reCEP+wJs4BLpEdgVkJn5Q7W7RXFGQvYI45wq3FMHMqcROGFRc X-Received: by 2002:a17:906:858f:: with SMTP id v15mr8680237ejx.238.1611795128230; Wed, 27 Jan 2021 16:52:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611795128; cv=none; d=google.com; s=arc-20160816; b=wS3/Wz1jW/wW+lOxYG3TEImHFGMed8O9+1eg1h5lcNWbO4xTSw0bxVmZ+IfuNJmdU3 K6c4fQbaRmueSqRpsVNQq0n+LwjFr3H/GrtYTf4O2eeqIWIuchFbOkT7dSTh8gtSoIue P2zx1rTt1qHSJJwrbQJGP58LltIiFiY3DBhk9LK8Z6lWO1nFABb+vuP1o0Qqw9Ea3P2C 1Yd5nNCquiLkp+k/g8Zp9dI/lgQfijjVroi03AWp1NS6JfMJULqGiklU4xVmVOwwSMHz dCWXTRO/fk35bySXuV6NlepB53vgi1jVm2jvyp/oH3/PBXOItrlgjC6mLeraLPdDy0tV 0Rrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=b+SV5nIKz2hw8NGdTknr690ZRcwFMpeF+xzeiZDbVgc=; b=rCOjRp6GiuK/y6qmCepeF18uJvLAhZkT9oiNlEAxGKZ2UIXgvMn5exvg/2b5ITZBje B3ntqaGJjCMXYEG2QmishmCc58bxRUyisH4VMVlHri+4uRXXxoJ7I9nDtSAa5mGJxs1k n61XfSwJ8CYiItPnEPywHzjuPu3cjnFZWAEfO8i7/eorog2WeTefkYhjzKQnXBJmubjz qYFwe1i5jR45NBkXwq9nSUew1tDaiZCumNB5UDKlFIUMrFPdasI/RwEaV0/ZaO9e69jR mGtTHJj8r4Q64ok410mzFBi/kuZcuYq1B3ZTvChz+hyd27TTvm492aq59efSZZU8egS1 XK/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MqxoCWHW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u1si296334ejf.754.2021.01.27.16.51.44; Wed, 27 Jan 2021 16:52:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MqxoCWHW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231674AbhA1Aj2 (ORCPT + 99 others); Wed, 27 Jan 2021 19:39:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:59172 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbhA1Aiy (ORCPT ); Wed, 27 Jan 2021 19:38:54 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2EE8D60C3D; Thu, 28 Jan 2021 00:38:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611794293; bh=tYOqKlJNe68s8knlGa09rULG0afNwiuJ8DHiuRlHmT8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MqxoCWHWBToX8n2PKuDZL0FSQLgOPv5IP+N92erMGtwiG0DlSq8DwNq7nDpqO2XWS GJ7YXMmF7U3YdCkQSRlewfIQdpEoq9teIVAt4LHElICHxgdUGPO13XbOoUI7RYcwFR 3BF3UX3natIy4CnJJEB8hhEfaNXcZrR+AAkBUsZEFTZCkHfEvYiYEgqXSZ9X8f+omv ipVloD6ll/9qHwUPBSszg8o5e39gcBL+A7tJwjgvMr3BI0GD6WoQCyf3MNP9PbjCWZ 2GehUitnv12Y+YLku91DonZME7aTw1ndMSfDROO+/5N7gapIMVry3qLjVYgO/3/1EJ fTlJZk6JJ72Zw== Date: Wed, 27 Jan 2021 16:38:12 -0800 From: Jakub Kicinski To: Oleksandr Mazur Cc: netdev@vger.kernel.org, jiri@nvidia.com, davem@davemloft.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 net-next] net: core: devlink: add 'dropped' stats field for DROP trap action Message-ID: <20210127163812.76fa0411@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210125123121.1540-1-oleksandr.mazur@plvision.eu> References: <20210125123121.1540-1-oleksandr.mazur@plvision.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Jan 2021 14:31:21 +0200 Oleksandr Mazur wrote: > Whenever query statistics is issued for trap with DROP action, > devlink subsystem would also fill-in statistics 'dropped' field. > In case if device driver did't register callback for hard drop > statistics querying, 'dropped' field will be omitted and not filled. > Add trap_drop_counter_get callback implementation to the netdevsim. > Add new test cases for netdevsim, to test both the callback > functionality, as well as drop statistics alteration check. > > Signed-off-by: Oleksandr Mazur Please stick to RFC since there is no upstream user for this (if you need to repost).