Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <877do3gaq9.fsf@m5Zedd9JOGzJrf0> <87zh0u540n.fsf@collabora.com>
In-Reply-To: <87zh0u540n.fsf@collabora.com>
From:   Yuxuan Shui <yshuiv7@gmail.com>
Date:   Thu, 28 Jan 2021 00:16:12 +0000
Message-ID: <CAGqt0zxVN2HpXrY=L0D7+6p3Lr1rCt_z_Aa=O_-VxfCG18Wbkg@mail.gmail.com>
Subject: Re: [PATCH] ptrace: restore the previous single step reporting behavior
To:     Gabriel Krisman Bertazi <krisman@collabora.com>
Cc:     linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
        kernel@collabora.com, tglx@linutronix.de, peterz@infradead.org,
        luto@kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Wed, Jan 27, 2021 at 11:55 PM Gabriel Krisman Bertazi
<krisman@collabora.com> wrote:
>
> Yuxuan Shui <yshuiv7@gmail.com> writes:
>
> > Commit 64eb35f701f04b30706e21d1b02636b5d31a37d2 changed when single step
> > is reported.
> >
> > Specifically, the report_single_step is changed so that single steps are
> > only reported when both SYSCALL_EMU and _TIF_SINGLESTEP are set, while
> > previously they are reported when _TIF_SINGLESTEP is set without
> > _TIF_SYSCALL_EMU being set.
> >
> > This behavior change breaks rr [1]
> >
> > This commit restores the old behavior.
> >
> > [1]: https://github.com/rr-debugger/rr/issues/2793
> >
> > Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
>
> Looks correct to me.
>
> To gather the right attention, you should directly CC the correct maintainers.

Thanks, will do.

>
> Fixes: 64eb35f701f0 ("ptrace: Migrate TIF_SYSCALL_EMU to use SYSCALL_WORK flag")
> Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.com>
>
> --
> Gabriel Krisman Bertazi


-- 

Regards
Yuxuan Shui