Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Wed, 27 Jan 2021 16:36:32 -0500
From:   Tejun Heo <tj@kernel.org>
To:     Dave Hansen <dave.hansen@intel.com>
Cc:     Saravanan D <saravanand@fb.com>, x86@kernel.org,
        dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org,
        linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH V2] x86/mm: Tracking linear mapping split events
Message-ID: <YBHc4JHc4ogwV93W@slm.duckdns.org>
References: <bd157a11-8e6b-5f44-4d91-d99adb9f8686@intel.com>
 <20210127175124.3289879-1-saravanand@fb.com>
 <YBHVCZscdVsxbFUk@slm.duckdns.org>
 <5562757e-578b-0ad7-1a9c-c64238283ab7@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5562757e-578b-0ad7-1a9c-c64238283ab7@intel.com>
Precedence: bulk

Hello,

On Wed, Jan 27, 2021 at 01:32:03PM -0800, Dave Hansen wrote:
> >>  arch/x86/mm/pat/set_memory.c  | 117 ++++++++++++++++++++++++++++++++++
> >>  include/linux/vm_event_item.h |   8 +++
> >>  mm/vmstat.c                   |   8 +++
> >>  3 files changed, 133 insertions(+)
> > 
> > So, now the majority of the added code is to add debugfs knobs which don't
> > provide anything that userland can't already do by simply reading the
> > monotonic counters.
> > 
> > Dave, are you still set on the resettable counters?
> 
> Not *really*.  But, you either need them to be resettable, or you need
> to expect your users to take snapshots and compare changes over time.
> Considering how much more code it is, though, I'm not super attached to it.

Saravanan, can you please drop the debugfs portion and repost?

Thanks.

-- 
tejun