Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 0uzsh/dP5+qR7PH2N15E4H15miijJkH/O5K6eNFhlazMqaMhxE2rv+WpVVXzR5M4Uq4YyMP2La
 1OnpwSXzkMkg==
IronPort-SDR: Kq78ATGb6zSuQed5PKw0bvAiX9cHwz4b4UTgafQsDmhHO9VX4lPah7PJoWsjLn9GScl4l4mH9v
 T0778ZGgfMug==
Subject: Re: [PATCH v8] perf stat: Fix wrong skipping for per-die aggregation
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com,
        Linux-kernel@vger.kernel.org, ak@linux.intel.com,
        kan.liang@intel.com, yao.jin@intel.com, ying.huang@intel.com
References: <20210125233525.13706-1-yao.jin@linux.intel.com>
 <20210127220827.GB284633@krava>
From:   "Jin, Yao" <yao.jin@linux.intel.com>
Message-ID: <58796d6e-fceb-ea1f-3a83-543569d5625c@linux.intel.com>
Date:   Thu, 28 Jan 2021 09:25:57 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <20210127220827.GB284633@krava>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Jiri,

On 1/28/2021 6:08 AM, Jiri Olsa wrote:
>> @@ -1385,7 +1386,8 @@ void evsel__exit(struct evsel *evsel)
>>   	zfree(&evsel->group_name);
>>   	zfree(&evsel->name);
>>   	zfree(&evsel->pmu_name);
>> -	zfree(&evsel->per_pkg_mask);
> sorry I did not notice before, but I think we need to call
> zero_per_pkg in here, otherwise we're leaking keys
> 
> jirka
> 

Sorry, I forgot to add the release code here. :(

I will rename zero_per_pkg to evsel__zero_per_pkg and move it to evsel.c and call 
evsel__zero_per_pkg in evsel__exit().

Thanks
Jin Yao