Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp673693pxb; Wed, 27 Jan 2021 18:45:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJws5pBz8annIVpo7H1UBkSJFuD1DLuAL6873lq3ESwkrX05LgIfjvC7T1Y+igQFftW8W/1U X-Received: by 2002:a50:fb96:: with SMTP id e22mr11465012edq.118.1611801942996; Wed, 27 Jan 2021 18:45:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611801942; cv=none; d=google.com; s=arc-20160816; b=E6CYvvj0/b6vKPXt8vNOVsdLfJaanA2j3yupp5I+ecGmblFfWZtdemd7zoCU4gc8fe 8GKqKO57+Elsp7Ox0aRzHvczug3+/Mtmldo9rfPGPIwvV6kmwO8tDmjmLaK1dI3YnSyl y0Z8tEIiXP8gFBczjTZaDo8DAj+0W3WCATuRdYqd62/hLyh3Ht/mz/OpinhzmTcNx3Xu XPyfG96cK81HuZ7ScCx+H17COOzRe+gdSRKLR4NCakON4LlcrohT2s7M76Z5klKwsvey PIgf6GB54I23IlNyqw1zqabes/YqWInSY4NohuXyfk5LxqxLoKIMM7G+R9qUixqOGFLZ n5HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from:ironport-sdr; bh=jqlk595DUAKGbyQiA/9ha9TTduCrblkQ1rIDbopzG2Y=; b=rNX+LvxWBxiJd02WDax9K2hOFY52hImXzctRo2iwO3iD/n3yh6QcFVuMoq2J21Wss4 ydru4T4Day6y5B6vyyinLN7Za/JWrmG5q4U071x1OMAaOzTt9aRU1Y0O5Qnbug/CSJMK kUIZAbxhEhqrT9HKgc/AbNbJA285RTgLiOTnypZfKd/VKrNHZ0OfqcOuSHaG0m16O2Ec cIiMkRozF68gAMU6DvSkli4aYuhaMN4VbpF/nCOmRZqAbslYBPblfzu32HIZG/gqTJ1J aII5gjMA2QOIaXo5Is6pwp1IHOegB3j7JdAiXltX0Qco6fHkfO2wYTGaIy7aoGPtNdg4 vKzg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lr6si1643755ejb.152.2021.01.27.18.45.17; Wed, 27 Jan 2021 18:45:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229578AbhA1Coq (ORCPT + 99 others); Wed, 27 Jan 2021 21:44:46 -0500 Received: from labrats.qualcomm.com ([199.106.110.90]:15550 "EHLO labrats.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229494AbhA1Cop (ORCPT ); Wed, 27 Jan 2021 21:44:45 -0500 IronPort-SDR: 1qfe8KWQ0zsYJ5yIEG2EWBqzePd7ksZfUONk2nY6ktZh+Z8fNvPtQ9JZvzqVZr7CZi6l71BabH 38SBqK54tlA5OQ3HCtwI34WYYu4aBNOQogjfPaWYjaVh3FabEJDYgKwVmEQ0ofQUqVo/ljNDQ+ Vj1pLBT2zFoKcIic2jTr1bHuknTt0UKLN1cly4a+TI0rkOxQJKAWVIexTWlVRCWmZylfHwwnwG Avhemo4rL3IPrNhoTx5KPq/DcsEzitJbj7d1XuNiLB3EADpx3dU1IiNNVWveGKMAAkVwHfaFYL EbY= X-IronPort-AV: E=Sophos;i="5.79,381,1602572400"; d="scan'208";a="47715382" Received: from unknown (HELO ironmsg03-sd.qualcomm.com) ([10.53.140.143]) by labrats.qualcomm.com with ESMTP; 27 Jan 2021 18:44:06 -0800 X-QCInternal: smtphost Received: from wsp769891wss.qualcomm.com (HELO stor-presley.qualcomm.com) ([192.168.140.85]) by ironmsg03-sd.qualcomm.com with ESMTP; 27 Jan 2021 18:44:04 -0800 Received: by stor-presley.qualcomm.com (Postfix, from userid 359480) id CD0CB219CD; Wed, 27 Jan 2021 18:44:04 -0800 (PST) From: Can Guo To: jaegeuk@kernel.org, asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, bjorn.andersson@linaro.org, linux-scsi@vger.kernel.org, kernel-team@android.com, cang@codeaurora.org Cc: Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Bean Huo , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] scsi: ufs: Give clk scaling min gear a value Date: Wed, 27 Jan 2021 18:42:42 -0800 Message-Id: <1611801769-20561-1-git-send-email-cang@codeaurora.org> X-Mailer: git-send-email 2.7.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The initialization of clk_scaling.min_gear by mistake. This change adds it back, otherwise clock scaling down would fail. Fixes: 4543d9d78227 ("scsi: ufs: Refactor ufshcd_init/exit_clk_scaling/gating()") Signed-off-by: Can Guo diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 36bcbb3..8ef6796 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -1602,6 +1602,9 @@ static void ufshcd_init_clk_scaling(struct ufs_hba *hba) if (!ufshcd_is_clkscaling_supported(hba)) return; + if (!hba->clk_scaling.min_gear) + hba->clk_scaling.min_gear = UFS_HS_G1; + INIT_WORK(&hba->clk_scaling.suspend_work, ufshcd_clk_scaling_suspend_work); INIT_WORK(&hba->clk_scaling.resume_work, -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.