Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp679867pxb; Wed, 27 Jan 2021 19:00:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJxSgFvikC0C5YietazcvkqZHzu2OJOKQL4mSs2xIkjRDqYDMdDnQ0k5fjiVYD5uYpnHTt57 X-Received: by 2002:a17:906:ae51:: with SMTP id lf17mr9292241ejb.330.1611802847218; Wed, 27 Jan 2021 19:00:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611802847; cv=none; d=google.com; s=arc-20160816; b=yp33lK3QYY+Xedl8qYafHU1raLA4QyoZcZaYL8yB2LDfv/MD6i+SAnjs/kufROYc6P APnnuG60wjwUscEYZHzP0Ry1xL/GHv1CqXlCzQUYFrA3zLTRmOdVN26BrtVkuU35BcW/ G48+400z6YOumk5Hih6kMxUPuFa/awG3tarf4aliQ4KMyj6zbJHD8RGZMaJVJQKtXmU6 A2iS/eXBA5zUT/JJ/WXYSAqk0bOPRtuSpk1wq2H5747ARznPyHGGCnlFFL+KnWmLXthb p2vdsae/j65pRjbfL2t31LiwMpr9eqIfo508YzR6u4PMwrD1XRl1KpDRmFp5h2KD+EYn 6N4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=WqqHKSetyIz7Atugh6aSINdh6ROOz9fhJYrG9bIoJKg=; b=Ze/UL6auWTKmstKgIyjiAXO7NgR9vHICi473khVIDhilD2lTzv+J+uuNkqwPL2+xVk oX6QUea5WSE8L3MzSIUDaBdxRG6IlfgV2WYyOSagt04k0txfwLI/CwQ11pCSUixM470g TxQhyBCG0IahntER7jqmihl8PyC41ffnnqo92XHLySRFBmKLDx3gmMjrQZ6fVLguv5ZO mkxLafei1CXZdifcwTMTtwHJZDPB7zKD9yup5hZZvYFRM49qIp3xsUAre5RcI5r7uHT+ uRptAxzvoxjLZ78Wg9NICj33vzLfzj3Xqf1ZbFHyEtFn79802h3Wj7ANxiowThG6D10a Lppg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f7si2203873edd.343.2021.01.27.19.00.23; Wed, 27 Jan 2021 19:00:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229551AbhA1C6o (ORCPT + 99 others); Wed, 27 Jan 2021 21:58:44 -0500 Received: from inva021.nxp.com ([92.121.34.21]:58804 "EHLO inva021.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229494AbhA1C6n (ORCPT ); Wed, 27 Jan 2021 21:58:43 -0500 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 76752200B57; Thu, 28 Jan 2021 03:57:56 +0100 (CET) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 67FC1200D88; Thu, 28 Jan 2021 03:57:52 +0100 (CET) Received: from localhost.localdomain (mega.ap.freescale.net [10.192.208.232]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id EFCF8402A9; Thu, 28 Jan 2021 03:57:46 +0100 (CET) From: Biwen Li To: mark.rutland@arm.com, leoyang.li@nxp.com, tglx@linutronix.de, jason@lakedaemon.net, maz@kernel.org Cc: linux-kernel@vger.kernel.org, jiafei.pan@nxp.com, linux-arm-kernel@lists.infradead.org, ran.wang_1@nxp.com, Biwen Li Subject: [v3] irqchip: ls-extirq: add IRQCHIP_SKIP_SET_WAKE to the irqchip flags Date: Thu, 28 Jan 2021 11:06:27 +0800 Message-Id: <20210128030627.41022-1-biwen.li@oss.nxp.com> X-Mailer: git-send-email 2.17.1 X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Biwen Li The ls-extirq driver doesn't implement the irq_set_wake() callback, while being wake-up capable. This results in ugly behaviours across suspend/resume cycles. Advertise this by adding IRQCHIP_SKIP_SET_WAKE to the irqchip flags Signed-off-by: Biwen Li --- Change in v3: - update description Change in v2: - Update description drivers/irqchip/irq-ls-extirq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-ls-extirq.c b/drivers/irqchip/irq-ls-extirq.c index 564e6de0bd8e..3c6ed7b4744d 100644 --- a/drivers/irqchip/irq-ls-extirq.c +++ b/drivers/irqchip/irq-ls-extirq.c @@ -65,7 +65,7 @@ static struct irq_chip ls_extirq_chip = { .irq_set_type = ls_extirq_set_type, .irq_retrigger = irq_chip_retrigger_hierarchy, .irq_set_affinity = irq_chip_set_affinity_parent, - .flags = IRQCHIP_SET_TYPE_MASKED, + .flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_SKIP_SET_WAKE, }; static int -- 2.17.1