Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp682138pxb; Wed, 27 Jan 2021 19:04:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJznKS9hVV5ferWmjxW9/Fe7nBdAzkOZLLzWsTIHxx6HGR7RhXUyyJVcSpBVipwKabH5vTC0 X-Received: by 2002:a50:acc1:: with SMTP id x59mr11825205edc.43.1611803081699; Wed, 27 Jan 2021 19:04:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611803081; cv=none; d=google.com; s=arc-20160816; b=tYYTsJI1yWQa4uO2a95S2Df23OWREatRfmIWfIKILvdBZs2p/GFQH5x727AjVKyP1d QrPYF25ZzkKye/8y6tp6mRJov5s4NOTmB4Pp+9t5pqYPaK0mQqF4bu8hAx/3lvZgtEwT tSm0C+MgFfd6PzHQYNTbMy8z0PszIVlWohhWxLOhQY9wvjdV9W54OTctZXVuORaqe4Bk pLlXicAxZLoFljIVSM0thQhJen0FIMj8+t267TNaLqt3Nc+2Txn7vkFJwEZPVz9jEB/6 KA+XRIfoYBfAQp1R2lG9mBsgFynwBdeIquFzgCAiErjZbIHW95VEF3oPTtGQRRg9NxB/ 1kBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=AP3tGQs6s5P8wm/ejXQRcsMvZE63wwCDiLfyGUDNGfs=; b=f+cfqnxWrel98oVUUTtDGGzD2K+h9FlXwjRBjZbgKPPVmxC78KbB+TzzaexH7eusRt NfFneXiA7YrGGQcaE9jhk5j5Py1E9p/HcGnrEWAVWQpTlGCW2fr5VtOjPbs1Z2hjoeSc FxBBcMH3v1g0tQKZ/wtDInO8MVUoDSlTiy45IiZhMe2r3loS6Y+MLHuAXMXMGOR6w38l WZksaJoMbs059VJauTShVmpCxwv/HnVBTK7XPP7xP7JdR39WFYf0QF6hiG/HoWuTkeCO 8EMl4GFRXR1lQFzv1VXcAdCj6J2UEJyRR4Rz4bcQ4fn0KD8YkOxL/vI58PvIct2CjqTZ h1Zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@paul-moore-com.20150623.gappssmtp.com header.s=20150623 header.b=WohYZJxn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y9si44859edm.453.2021.01.27.19.04.15; Wed, 27 Jan 2021 19:04:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@paul-moore-com.20150623.gappssmtp.com header.s=20150623 header.b=WohYZJxn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231178AbhA1DA4 (ORCPT + 99 others); Wed, 27 Jan 2021 22:00:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229739AbhA1DAy (ORCPT ); Wed, 27 Jan 2021 22:00:54 -0500 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 650D5C061574 for ; Wed, 27 Jan 2021 19:00:14 -0800 (PST) Received: by mail-ed1-x532.google.com with SMTP id z22so4907556edb.9 for ; Wed, 27 Jan 2021 19:00:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AP3tGQs6s5P8wm/ejXQRcsMvZE63wwCDiLfyGUDNGfs=; b=WohYZJxnkJWs7NUVxkokLpSvh3aAHm2vQIXOj9GWvPnRR5T21Lg8BGQhEbGdVR2vVm 2oxfZ9l8wkZqomdDEA9hoK61SjNAlGoDAFsUyiY1xkNrmhXePZ1Sr5mvv41ARAWPYS7u GbbFV/towIWajZDXdKWz/4MlrN0665aWjhpQSLsKrLCtw5+V4rdA9JgNWgODMrojrDD8 A7XKdvcYEHwy4hquJ/wG5xNRSrzs71yTDDursIPIC5MixJXC1j0knZNQlF8ZFbhz2hZ+ /il6MsyYVgig7FrlcGMB7ZwUemtPb8ZYRy6iUuKTnYage2YlZpj326CCKhlpn2xCFrma 77Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AP3tGQs6s5P8wm/ejXQRcsMvZE63wwCDiLfyGUDNGfs=; b=YqLB3BeeV0L9Bncso1LUR6F53AxRVVDLrf/ql/GG/nuLElzlPK9iAey4omq7KTPH2S PeafhS4t2nZYPQ7dmu0zhNqg6RSsoA5+o+AUNirZU3wUtPu7NHdr58VcPIM+KDEfkJpu 0T6n0ttYanSeYsIwGwmsX9pQcV6rZMN3M3TwyzYmG9ToTci43yX2h4QT45eqvFoMIBGZ lZ79YHU+ARK/kziMfNfAnHlWSiSNtlXB0dtaHa8PjtRHkI6DHbioScWqCox6362JY5OQ HO8xyOg11Ie3BlD5qQuit4/u0COD+xgMhfYEiqBREUl7P+w0TAtTWO1mD7a6gPvDspZ4 QFHw== X-Gm-Message-State: AOAM532xSsCNweOAyhaerjOekSJPTyfRGZq73H0KEUrj1YzEWURDQuv5 ghaokdimPyPwdpXcC0ZewruEr13V5HboUvxxa8Sw X-Received: by 2002:a05:6402:54d:: with SMTP id i13mr11785340edx.12.1611802811444; Wed, 27 Jan 2021 19:00:11 -0800 (PST) MIME-Version: 1.0 References: <20210127025144.24253-1-yang.yang29@zte.com.cn> In-Reply-To: <20210127025144.24253-1-yang.yang29@zte.com.cn> From: Paul Moore Date: Wed, 27 Jan 2021 22:00:00 -0500 Message-ID: Subject: Re: [PATCH v2] audit: Make audit_filter_syscall() return void To: menglong8.dong@gmail.com Cc: Eric Paris , linux-audit@redhat.com, linux-kernel@vger.kernel.org, Yang Yang , Richard Guy Briggs Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2021 at 9:52 PM wrote: > > From: Yang Yang > > No invoker uses the return value of audit_filter_syscall(). > So make it return void, and amend the comment of > audit_filter_syscall(). > > Changes since v1: > - amend the comment of audit_filter_syscall(). > > Signed-off-by: Yang Yang > Reviewed-by: Richard Guy Briggs > --- > kernel/auditsc.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) This is a simple enough patch so I think merging it during -rc5 should be okay; merged into audit/next - thanks! -- paul moore www.paul-moore.com