Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 4GAoTuFXJmimnhVoeJMHbsuMuW6d78TNmCrjuwRnvnOmEg3LADJ8t8JYPJ400v1wAVVGLsKDw/
 CgaqsMUhCbQg==
IronPort-SDR: /Jc3c5jYCj7kC1arPXYY9H/0QUKyDtq7ivr/H3f0v0YmkuXskfIvnjXSTUxpWD03sHZaOGpmQX
 QKdh4vvviHnQ==
Subject: Re: [PATCH 1/2] perf script: Support filtering by hex address
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com,
        Linux-kernel@vger.kernel.org, ak@linux.intel.com,
        kan.liang@intel.com, yao.jin@intel.com
References: <20210124232750.19170-1-yao.jin@linux.intel.com>
 <20210127222905.GD284633@krava>
From:   "Jin, Yao" <yao.jin@linux.intel.com>
Message-ID: <60d102fa-d98a-6182-0a1d-b78122fed574@linux.intel.com>
Date:   Thu, 28 Jan 2021 11:31:26 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <20210127222905.GD284633@krava>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Jiri,

On 1/28/2021 7:13 AM, Jiri Olsa wrote:
>> @@ -709,6 +725,26 @@ int machine__resolve(struct machine *machine, struct addr_location *al,
>>   			ret = strlist__has_entry(symbol_conf.sym_list,
>>   						al_addr_str);
>>   		}
>> +		if (!ret && al->map) {
>> +			snprintf(al_addr_str, sz, "0x%"PRIx64,
>> +				al->map->unmap_ip(al->map, al->addr));
>> +			ret = strlist__has_entry(symbol_conf.sym_list,
>> +						 al_addr_str);
>> +			if (!ret) {
>> +				/* Check for hex without "0x" prefix */
>> +				snprintf(al_addr_str, sz, "%"PRIx64,
>> +					al->map->unmap_ip(al->map, al->addr));
>> +				ret = strlist__has_entry(symbol_conf.sym_list,
>> +							 al_addr_str);
>> +			}
> that seems tricky.. what if user specify more leading zeros,
> I think it'd be better to search intlist instead
> 
> we could move all 'address' entries from sym_list to
> new intlist (in symbol__init) and use it for this search
> 
> jirka
> 

intlist now only supports 'int' type.

I'm considering to use 'long' to replace original 'int' in struct int_node.

struct int_node {
	struct rb_node rb_node;
-	int i;
+	long i;
	void *priv;
};

On 32 bits platform, sizeof(long) is 4, and on 64 bits platform, sizeof(long) is 8. So that should 
be OK for storing the values such as pid/tid and address.

I'm not very clear why currently it uses 'int' for i in struct int_node, maybe something I don't 
understand correctly. Please correct me if my understanding is wrong.

Thanks
Jin Yao