Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp712657pxb; Wed, 27 Jan 2021 20:21:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJwuriyRF2ldVQQeCLBFozbgMm+6Ld+MqZ2Q18XGv3Cx9LIN614BWdaVjxz7kL75RsSc3v0D X-Received: by 2002:a17:906:fc18:: with SMTP id ov24mr5540210ejb.529.1611807664929; Wed, 27 Jan 2021 20:21:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611807664; cv=none; d=google.com; s=arc-20160816; b=zh08PfWkHTCnpYzGmRM1ptvWKTE9zn4t9vUV5n+eE3t8k0Y4d6hmtaa7uJgMkn86BU XbDvcAKeA7D7f8SI5fZsMHbsNowRZG2Lxb0IqgBOyyNtqUp+stxVgHBGfK0LiTE1DJf3 8YLfgt1b3KcYLKJC8s8jc9/27aU8YekEZQbqx+yigP9Zm8jDBv8mUr/tlw11bpJinY6L M4SjzuWeKrZG7F44EemZm9LR5bKHZcRMvpoQ961ypaO4+Zc4FZLCX0uitt9F9kcEp6I7 am7jsoESh2qggQcNX14KhdA1LK2bZUmp5assHUcAeFkh6RdrdZy88AV+Kp8C44uaL+5H EEXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:ironport-sdr; bh=evafd00Akbv0Auz/wPT0OohFIcPdaqusXfUWv0GnFe8=; b=V/J/XSIcE9onk6pbErSYlPiCvdxcYt6aWVnH1UT4StnFu3d4uaaaCiiYv7Uvoyq2jc PaseoojKJ0ZgyCl5UKeL1D4lB4xJoCON8akTmBDrIcRdADDQFziRX1soqwY7mwY4RATq +qyxQADjP6vZjFd9f5ZvjwxlQadug6ec/VPXAxgSkh7gXnrna2+pFXSAadk286FwlZYk D3SwKGLmJBDwMX2P8DvgRvNUw17/svWjQHFaIu9Lt8xbdO36YwFHUEF1+EmPQh+gYWbY JqJuMLGnicO2JK/Ceq6IcT+RvLq7QMCYJVPFG+upbwklg4cnqxakYXIu5eyvZ4cE1uJg NTvQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bw26si1849608ejb.644.2021.01.27.20.20.41; Wed, 27 Jan 2021 20:21:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231287AbhA1ESL (ORCPT + 99 others); Wed, 27 Jan 2021 23:18:11 -0500 Received: from labrats.qualcomm.com ([199.106.110.90]:40784 "EHLO labrats.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231243AbhA1ESF (ORCPT ); Wed, 27 Jan 2021 23:18:05 -0500 IronPort-SDR: uis1MRu9wOS/NldmsOhX/HutjYmbB/JNYuv7iW4+GFNHgfwxrlgqtngdvcI3YTiwnSKBYMMnX3 H+aHPlk67ZGR3x5e/w8t6p7o6SWAbgqZj8ezrRNIjGqswB0qS3ae+ywx9AkbaisKL7ITpHRRvR npbnw8GZGQTOJHBS+KCQ/aIS3/uSce0zdAwVEoXaDubkLqx1PhS/w7pwnk0lH33jVQoXpdYf35 iVzs2ISTKp8id5pXpj01jDYHUAm8ZAm0eIy8zEvRUZ7UP5CApvO9s3pv4nAujA4kepIRQMcOY+ UZw= X-IronPort-AV: E=Sophos;i="5.79,381,1602572400"; d="scan'208";a="47715649" Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by labrats.qualcomm.com with ESMTP; 27 Jan 2021 20:17:45 -0800 X-QCInternal: smtphost Received: from wsp769891wss.qualcomm.com (HELO stor-presley.qualcomm.com) ([192.168.140.85]) by ironmsg02-sd.qualcomm.com with ESMTP; 27 Jan 2021 20:17:43 -0800 Received: by stor-presley.qualcomm.com (Postfix, from userid 359480) id 4A40A219A2; Wed, 27 Jan 2021 20:17:43 -0800 (PST) From: Can Guo To: jaegeuk@kernel.org, bvanassche@acm.org, asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, cang@codeaurora.org Cc: Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Bean Huo , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 1/3] scsi: ufs: Fix task management request completion timeout Date: Wed, 27 Jan 2021 20:16:02 -0800 Message-Id: <1611807365-35513-2-git-send-email-cang@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1611807365-35513-1-git-send-email-cang@codeaurora.org> References: <1611807365-35513-1-git-send-email-cang@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ufshcd_tmc_handler() calls blk_mq_tagset_busy_iter(fn = ufshcd_compl_tm()), but since blk_mq_tagset_busy_iter() only iterates over all reserved tags and requests which are not in IDLE state, ufshcd_compl_tm() never gets a chance to run. Thus, TMR always ends up with completion timeout. Fix it by calling blk_mq_start_request() in __ufshcd_issue_tm_cmd(). Fixes: 69a6c269c097 ("scsi: ufs: Use blk_{get,put}_request() to allocate and free TMFs") Signed-off-by: Can Guo --- drivers/scsi/ufs/ufshcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 8da75e6..c0c5925 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -6395,6 +6395,7 @@ static int __ufshcd_issue_tm_cmd(struct ufs_hba *hba, spin_lock_irqsave(host->host_lock, flags); task_tag = hba->nutrs + free_slot; + blk_mq_start_request(req); treq->req_header.dword_0 |= cpu_to_be32(task_tag); -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.