Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20190717222340.137578-4-saravanak@google.com> <20191125112812.26jk5hsdwqfnofc2@vireshk-i7>
 <20200127061118.5bxei6nghowlmf53@vireshk-i7> <b0be1275-c5cb-8171-58fa-64d65f60eaf8@codeaurora.org>
 <20200130042126.ahkik6ffb5vnzdim@vireshk-i7> <CAJMQK-gmO-tLZkRRxRdgU9eyfo95omw_RnffFVdhv2A6_9T-nQ@mail.gmail.com>
 <20210118073430.a6lr3ynkd2duv34l@vireshk-i7> <CAJMQK-j6EYjU1z_SUY4MFEJO6qTtOH7mQ_QWj2iUMewBKAghng@mail.gmail.com>
 <20210127115415.7zjpf6uaybwswno3@vireshk-i7> <CAJMQK-hgeOv9XDasmmWGguxyC62SCsSoX5_enEb46whE8_Emew@mail.gmail.com>
 <20210128041342.owkjl4voodw4dcmf@vireshk-i7>
In-Reply-To: <20210128041342.owkjl4voodw4dcmf@vireshk-i7>
From:   Hsin-Yi Wang <hsinyi@chromium.org>
Date:   Thu, 28 Jan 2021 13:05:02 +0800
Message-ID: <CAJMQK-ihjnTWXVuKZXE=cX2TpVaFMTreZ7fdieWm7PRbB8byxg@mail.gmail.com>
Subject: Re: [PATCH v3 3/5] OPP: Improve require-opps linking
To:     Viresh Kumar <viresh.kumar@linaro.org>
Cc:     Sibi Sankar <sibis@codeaurora.org>,
        Saravana Kannan <saravanak@google.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
        Stephen Boyd <sboyd@kernel.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Android Kernel Team <kernel-team@android.com>,
        Linux PM <linux-pm@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        "Andrew-sh.Cheng" <andrew-sh.cheng@mediatek.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jan 28, 2021 at 12:13 PM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 27-01-21, 22:40, Hsin-Yi Wang wrote:
> > Hi Viresh,
> >
> > I tested this patch with devfreq passive governor[1] and mt8183
> > cci[2]. It's also working as expected.
>
> I hope I can add your Tested-by for the patch then, right ?
>
Yes, thanks!

Tested-by: Hsin-Yi Wang <hsinyi@chromium.org>

> > [1] https://patchwork.kernel.org/project/linux-pm/cover/20190724014222.110767-1-saravanak@google.com/
> > (patch 2,4,5)
> > [2] https://patchwork.kernel.org/project/linux-mediatek/cover/1594348284-14199-1-git-send-email-andrew-sh.cheng@mediatek.com/
> >
> > In my testing case, required_opp_table is not genpd case (mt8183 cci
> > is not genpd), so I remove the following constraint. Does that make
> > sense to you?
> >
> > @@ -377,13 +377,6 @@ static void lazy_link_required_opp_table(struct
> > opp_table *new_table)
> >         struct dev_pm_opp *opp;
> >         int i, ret;
> >
> > -       /*
> > -        * We only support genpd's OPPs in the "required-opps" for now,
> > -        * as we don't know much about other cases.
> > -        */
> > -       if (!new_table->is_genpd)
> > -               return;
> > -
> >         mutex_lock(&opp_table_lock);
>
> We will perhaps need more changes than that, but those should be done
> separately when you try to add a user for the same.
>

Ack.

> --
> viresh