Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <a09eea7616881d40d2db2fb5fa2770dc6166bdae.1611456351.git.tommyhebb@gmail.com>
 <20210125100540.55wbgdsem3htplx3@pali> <20210125201938.GB78651@roeck-us.net>
 <20210125202130.afwhcuznietmqo5s@pali> <20210127230001.7zeeczkfj33zj5sw@pali> <aef96a2a-9e27-32a2-62a5-92b8d87b9136@roeck-us.net>
In-Reply-To: <aef96a2a-9e27-32a2-62a5-92b8d87b9136@roeck-us.net>
From:   Bob Hepple <bob.hepple@gmail.com>
Date:   Thu, 28 Jan 2021 15:08:01 +1000
Message-ID: <CAHzpm2jOi1VnQR_kun-Y15jXskExYF7dV-o0-T0-pvLy+J8jsQ@mail.gmail.com>
Subject: Re: [PATCH] hwmon: (dell-smm) Add XPS 15 L502X to fan control blacklist
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali@kernel.org>,
        Thomas Hebb <tommyhebb@gmail.com>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

I've posted something on the Dell Community site as I can't get to the
proper support pages (expired warranty).

https://www.dell.com/community/XPS/Linux-kernel-regression-in-fan-control-d=
ell-smm-hwmon-c-on-XPS/m-p/7794672#M77826

I have read that the Dell Social Networks people forward this sort of
stuff to the Dell Developers ...

Cheers

Bob

On Thu, 28 Jan 2021 at 11:46, Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 1/27/21 3:00 PM, Pali Roh=C3=A1r wrote:
> > On Monday 25 January 2021 21:21:30 Pali Roh=C3=A1r wrote:
> >> On Monday 25 January 2021 12:19:38 Guenter Roeck wrote:
> >>> On Mon, Jan 25, 2021 at 11:05:40AM +0100, Pali Roh=C3=A1r wrote:
> >>>> On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
> >>>>> It has been reported[0] that the Dell XPS 15 L502X exhibits similar
> >>>>> freezing behavior to the other systems[1] on this blacklist. The is=
sue
> >>>>> was exposed by a prior change of mine to automatically load
> >>>>> dell_smm_hwmon on a wider set of XPS models. To fix the regression,=
 add
> >>>>> this model to the blacklist.
> >>>>>
> >>>>> [0] https://bugzilla.kernel.org/show_bug.cgi?id=3D211081
> >>>>> [1] https://bugzilla.kernel.org/show_bug.cgi?id=3D195751
> >>>>>
> >>>>> Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all X=
PS models")
> >>>>> Cc: stable@vger.kernel.org
> >>>>> Reported-by: Bob Hepple <bob.hepple@gmail.com>
> >>>>> Tested-by: Bob Hepple <bob.hepple@gmail.com>
> >>>>> Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
> >>>>> ---
> >>>>>
> >>>>>  drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
> >>>>>  1 file changed, 7 insertions(+)
> >>>>>
> >>>>> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-sm=
m-hwmon.c
> >>>>> index ec448f5f2dc3..73b9db9e3aab 100644
> >>>>> --- a/drivers/hwmon/dell-smm-hwmon.c
> >>>>> +++ b/drivers/hwmon/dell-smm-hwmon.c
> >>>>> @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fa=
n_support_dmi_table[] __initdata =3D {
> >>>>>                   DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"),
> >>>>>           },
> >>>>>   },
> >>>>> + {
> >>>>> +         .ident =3D "Dell XPS 15 L502X",
> >>>>> +         .matches =3D {
> >>>>> +                 DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> >>>>> +                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XP=
S L502X"),
> >>>>
> >>>> Hello! Are you sure that it is required to completely disable fan
> >>>> support? And not only access to fan type label for which is differen=
t
> >>>> blaclist i8k_blacklist_fan_type_dmi_table?
> >>>>
> >>>
> >>> I'll drop this patch from my branch. Please send a Reviewed-by: or Ac=
ked-by: tag
> >>> if/when I should apply it.
> >>
> >> Of course! We will just wait for Bob test results.
> >
> > Guenter, now we have all needed information, fix is really needed in
> > this form. So you can add my:
> >
> > Reviewed-by: Pali Roh=C3=A1r <pali@kernel.org>
> >
>
> Applied (again)
>
> Thanks,
> Guenter