Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp781794pxb; Wed, 27 Jan 2021 23:08:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJyDopwY+bF/kUZePh+ZagbHR2eOqXDty4gHecU8yQ0AIoazPbCVkOWDzUG04WqgysHS+o4B X-Received: by 2002:a05:6402:6c4:: with SMTP id n4mr12818242edy.257.1611817723220; Wed, 27 Jan 2021 23:08:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611817723; cv=none; d=google.com; s=arc-20160816; b=PshO4lmDMqQeEg+e+1rC0LIL93/1uE/3U4v4nuc13FitB+PZKnXXCSnoWne4sbEh5K 9OURFSY3K3jOpwCPYXrAAvUwIkUrf6FMlqKw3/o4f/HH6iHzpAp/VdBogmuK6kd/dmLM ad0OlzUf/46h4Od7oOlWBrLGv8xJLUsJPl89+PTkhJR1vYAZWpB47/cjd2pFX0GbSTis nw9jUO+L9EO8s6OtRtU4LSKfi5XcKTcwHwKS4D5oI39tTkmqpGWzG6AedgcbfOcLFcap 7+mN+NVViRDIRnyf2YmprgHkUJv9qQzUev5MywdEzF+xd1pxqSoa1iG+2EEQVXS0A5pv KPwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=4koKAdYgRop0jHJt01vFDOEfv6CKTaeQc67fRzO3zpo=; b=fVAUAlRwHOJRzQOgiQdLohOVA+8aKWqz3ystIFuT9bK1/XxHA1sjKA9YQlM/59bZ6Z F2jill9nZnE8k6nRu8S6Stc0my9yEqJ7UwnJDEIVfm2ecLVH7jOuY/Xbt9ksvC7JON4v 7STIFURnepIQQHgZNEJORYT8UbsfMgaJtsCYwgHD+9+foPNhdGWmN3P73ktn056AWMMO bpvAQAGMUmzCDKaL2vNTP7UFbTQ6nyn6boReidTwqvJwRus3+A59xjA9Op/VJAJHdOYT 2DtxoJl5LJMWQ6yVy8Tcj+qmuVo2ON3eYDWlLEJHMNPGKCXtU+pucfnBfeEzTtgvl4iZ XJwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e8si1904566ejj.540.2021.01.27.23.08.19; Wed, 27 Jan 2021 23:08:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229504AbhA1HFe (ORCPT + 99 others); Thu, 28 Jan 2021 02:05:34 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:11456 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231442AbhA1HFN (ORCPT ); Thu, 28 Jan 2021 02:05:13 -0500 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4DRBJf30QpzjBjN; Thu, 28 Jan 2021 15:03:30 +0800 (CST) Received: from [10.136.110.154] (10.136.110.154) by smtp.huawei.com (10.3.19.210) with Microsoft SMTP Server (TLS) id 14.3.498.0; Thu, 28 Jan 2021 15:04:27 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: flush data when enabling checkpoint back To: Jaegeuk Kim , , , CC: References: <20210127014434.3431893-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: Date: Thu, 28 Jan 2021 15:04:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20210127014434.3431893-1-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.110.154] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/1/27 9:44, Jaegeuk Kim wrote: > During checkpoint=disable period, f2fs bypasses all the synchronous IOs such as > sync and fsync. So, when enabling it back, we must flush all of them in order > to keep the data persistent. Otherwise, suddern power-cut right after enabling > checkpoint will cause data loss. > > Fixes: 4354994f097d ("f2fs: checkpoint disabling") > Cc: stable@vger.kernel.org > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks,