Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 28 Jan 2021 08:54:16 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc:     linux-kernel@vger.kernel.org, speakup@linux-speakup.org
Subject: Re: [PATCH] speakup: Make dectlk flush timeout configurable
Message-ID: <YBJtqGn/ZpdFpNlg@kroah.com>
References: <20210127234444.1038813-1-samuel.thibault@ens-lyon.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210127234444.1038813-1-samuel.thibault@ens-lyon.org>
Precedence: bulk

On Thu, Jan 28, 2021 at 12:44:44AM +0100, Samuel Thibault wrote:
> In case the serial port or cable got faulty, we may not be getting
> acknowledgements any more. The driver then currently waits for 4s to
> avoid jamming the device. This makes this delay configurable.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
>  drivers/accessibility/speakup/speakup_dectlk.c | 11 ++++++++++-
>  drivers/accessibility/speakup/spk_types.h      |  3 ++-
>  drivers/accessibility/speakup/synth.c          |  3 +++
>  drivers/accessibility/speakup/varhandlers.c    |  1 +
>  4 files changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/accessibility/speakup/speakup_dectlk.c b/drivers/accessibility/speakup/speakup_dectlk.c
> index d75de36..580ec79 100644
> --- a/drivers/accessibility/speakup/speakup_dectlk.c
> +++ b/drivers/accessibility/speakup/speakup_dectlk.c
> @@ -78,6 +78,8 @@ static struct kobj_attribute direct_attribute =
>  	__ATTR(direct, 0644, spk_var_show, spk_var_store);
>  static struct kobj_attribute full_time_attribute =
>  	__ATTR(full_time, 0644, spk_var_show, spk_var_store);
> +static struct kobj_attribute flush_time_attribute =
> +	__ATTR(flush_time, 0644, spk_var_show, spk_var_store);

__ATTR_RW()?

Also, no Documentation/ABI/ update for the new one user-visable
attribute?  Please fix up.

thanks,

greg k-h