Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp807906pxb; Thu, 28 Jan 2021 00:05:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJynMq06aem/jbr5QzcF03Dti+Y7FW6rwPwF/FVqwbBIKFPhBJMaFkUvtCdVrhErFRW+IKuZ X-Received: by 2002:a17:906:bc5a:: with SMTP id s26mr9613241ejv.327.1611821128835; Thu, 28 Jan 2021 00:05:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611821128; cv=none; d=google.com; s=arc-20160816; b=oFABJUJcX2pHMaVAD7z3j3j4kQ/GtKrl5MN5MJGOvXdSuJ9FnwbWXz4aMgz7/o8s50 jMy6V8Zotq0XHvuO1KBxb89we5knUYHdd4SeiwBtrB9CFcQCVO8gOUAWWYwuQTYxY9F7 j1qMKoyAeUwmdbjXzdGorQC8R6tYDHM/u5JAp2SCiqJbad4AJnO6BYBTSKLcS+vavVcv rd+zWc34lQmECXL64YrRZIAP6eedf+UrSx8QGhn2MuZ/CLGQ6lEnArMhNM52KiB8iK0s IMj+K6d7SmPzeWj81bItVl5kv6j9QVRklFTr9WMBLJbx8mDDpDCQXIL8w0vDCIQvGsD8 SmdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=VFvlavdQj3vCTWkwoAVwJZYrgCNBuE8sgIQdKiGhY+w=; b=qixSEaqJ9wMvdFsYZTYY7QaxVqX4t951XyXuEYwMscZ//BND4WAmRnM1h5rCLnzgcE 1mp3lGuay2LyR1je6pWZ7QYods6SriKM0N/uEhLUE12mXIc3ESqLgmpypT2h87kM9mbY WTdxu7CeuXsIH4AF2OhHlHcsa9aCp+6PhVTNxTXdUw+FZ++C9HCjmolPWa8HdV5ELUqY ZdmwN8rY1Zd+066agjRGcAhULyCqV/Wiio2swRjLpm+hgY1PG2QaOmnKstefFv04tWOI BrjOWQrO+y2Of3snNn7h+nMMAieR9MO2oLvX+WfH+WXPjNEXPwJbCtHBzvXEgukHaMWS suIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d12si2160533ejb.358.2021.01.28.00.05.04; Thu, 28 Jan 2021 00:05:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232208AbhA1IDO (ORCPT + 99 others); Thu, 28 Jan 2021 03:03:14 -0500 Received: from mail-ot1-f51.google.com ([209.85.210.51]:45872 "EHLO mail-ot1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232210AbhA1IAJ (ORCPT ); Thu, 28 Jan 2021 03:00:09 -0500 Received: by mail-ot1-f51.google.com with SMTP id n42so4358238ota.12; Wed, 27 Jan 2021 23:59:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VFvlavdQj3vCTWkwoAVwJZYrgCNBuE8sgIQdKiGhY+w=; b=V569t6Aun8zU7H8/nsKR/dXIhorUn/YIB/XD30A81SMdT3I+cIolhedJOzH30a+EZy G+VVkNtLZwPZs/1LQUKvKnq6fJx+vc2x5mx18R2ASbBwBw1tx2ub/pMB5NNPFMjqjNX7 XnWxqIIbgMR5VpTDPZC3ASjpIx5LzkD2GKOlgEh+NHUvQwPxLPtdA2yAUfxIyTSGDjMd KUKVD+ZtqouxMAj/yasQFRpBnPPG5F2iaxyq4qIBYni37s+nBggNf9Q5BUAC5KWcMbC6 ICcQzFFwKzyj/1065FUmexZPcuW3nOSNG0hh5sODdCgxvAd0D2IDZta7Q7JCBp/iTEz+ EckQ== X-Gm-Message-State: AOAM531enlXV19QvsrjOBYL6D9eIkEkaBZIbgI5JI4QvMYdtU82ON2Ai i75IwbUgF52l8bcP2NOp7xaCePuDyS+6PT5fW5l+Y4LO X-Received: by 2002:a9d:c01:: with SMTP id 1mr10464911otr.107.1611820723093; Wed, 27 Jan 2021 23:58:43 -0800 (PST) MIME-Version: 1.0 References: <20210128005110.2613902-1-masahiroy@kernel.org> <20210128005110.2613902-12-masahiroy@kernel.org> In-Reply-To: <20210128005110.2613902-12-masahiroy@kernel.org> From: Geert Uytterhoeven Date: Thu, 28 Jan 2021 08:58:32 +0100 Message-ID: Subject: Re: [PATCH 11/27] m68k: add missing FORCE and fix 'targets' to make if_changed work To: Masahiro Yamada Cc: Linux-Arch , "the arch/x86 maintainers" , "open list:TENSILICA XTENSA PORT (xtensa)" , "linux-ia64@vger.kernel.org" , Parisc List , linux-kbuild , Linux-sh list , linux-um , Linux Kernel Mailing List , "open list:BROADCOM NVRAM DRIVER" , linux-m68k , alpha , sparclinux , linuxppc-dev , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 28, 2021 at 1:54 AM Masahiro Yamada wrote: > The rules in this Makefile cannot detect the command line change because > the prerequisite 'FORCE' is missing. > > Adding 'FORCE' will result in the headers being rebuilt every time > because the 'targets' addition is also wrong; the file paths in > 'targets' must be relative to the current Makefile. > > Fix all of them so the if_changed rules work correctly. > > Signed-off-by: Masahiro Yamada Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds