Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 28 Jan 2021 09:19:58 +0100
Message-ID: <s5h35ylxykx.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        "Kenneth R . Crudup" <kenny@panix.com>,
        Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "open list:HIBERNATION (aka Software Suspend, aka swsusp)" 
        <linux-pm@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PM: sleep: core: Resume suspended device if direct-complete is disabled
In-Reply-To: <CAAd53p5cg=ye5DnXAhb89HoUyJG6ecx3-OQp4ntgFumQWSnxQA@mail.gmail.com>
References: <20201231060319.137133-1-kai.heng.feng@canonical.com>
        <s5h7dnxxz1k.wl-tiwai@suse.de>
        <CAAd53p5cg=ye5DnXAhb89HoUyJG6ecx3-OQp4ntgFumQWSnxQA@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 28 Jan 2021 09:15:10 +0100,
Kai-Heng Feng wrote:
> 
> On Thu, Jan 28, 2021 at 4:09 PM Takashi Iwai <tiwai@suse.de> wrote:
> >
> > On Thu, 31 Dec 2020 07:03:19 +0100,
> > Kai-Heng Feng wrote:
> > >
> > > HDA controller can't be runtime-suspended after commit 215a22ed31a1
> > > ("ALSA: hda: Refactor codjc PM to use direct-complete optimization"),
> > > which enables direct-complete for HDA codec.
> > >
> > > The HDA codec driver doesn't expect direct-complete will be disabled
> > > after it returns a positive value from prepare() callback. So freeze()
> > > is called directly when it's runtime-suspended, breaks the balance of
> > > its internal codec_powered counting.
> > >
> > > So if a device is prepared for direct-complete but PM core breaks the
> > > assumption, resume the device to keep PM operations balanced.
> > >
> > > Fixes: 215a22ed31a1 ("ALSA: hda: Refactor codec PM to use direct-complete optimization")
> > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> >
> > Kai-Heng, is this fix still needed for 5.11?
> 
> No it's not needed anymore because "ALSA: hda: Balance runtime/system
> PM if direct-complete is disabled" is in place.
> 
> >
> > The description mentions about HD-audio controller, while the recent
> > revert was the HD-audio codec, so I suppose it's still affected?
> 
> Not affected anymore if above mentioned patch is applied.

OK, thanks for clarification!


Takashi